fix: replace <- with = for named argument in ecdf_intervals() call#454
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an R argument-passing bug where L <- n_chain was used inside an ecdf_intervals() call, causing an unintended assignment rather than a named argument.
Changes:
- Replace
<-with=for theLargument in theecdf_intervals()call inmcmc_rank_ecdf(). - Add a NEWS entry describing the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| R/mcmc-traces.R | Corrects ecdf_intervals() invocation to use a proper named argument (L = n_chain). |
| NEWS.md | Documents the fix in the development NEWS section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 35 35
Lines 5864 5864
=======================================
Hits 5779 5779
Misses 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
left a comment
There was a problem hiding this comment.
Thanks! This looks good but NEWS.md needs to be fixed (it mentions functions that don't exist). Also I think there is too much detail in NEWS.md for a small change like this. It can just say "Fix assignment-in-call bug in mcmc_rank_ecdf()", it doesn't need to describe it in so much detail
|
Thanks, merging now. |
Fix #453
Fixes the use of
<-(assignment operator) instead of=(named argument) when passingLtoecdf_intervals()inR/mcmc-traces.R.