Remove dead modify_aes_() and fix deprecated size usage in helpers#446
Merged
jgabry merged 2 commits intostan-dev:masterfrom Mar 10, 2026
Merged
Conversation
- Remove unused modify_aes_() that wrapped the deprecated aes_() (stan-dev#444) - Rename size param to linewidth in grid_lines() and grid_lines_y() (stan-dev#445) - Fix doc examples using size where linewidth is expected (stan-dev#445) Fixes stan-dev#444, fixes stan-dev#445
jgabry
requested changes
Mar 10, 2026
Member
jgabry
left a comment
jgabry
left a comment
There was a problem hiding this comment.
Thanks! Just one small change.
Member
|
Also there's a test that needs to be updated: https://github.com/stan-dev/bayesplot/actions/runs/22903567636/job/66472428428?pr=446#step:7:1277 |
grid_lines() is exported, so we can't just drop the size parameter without breaking user code. Keep it with a lifecycle deprecation warning pointing to linewidth. Also adds lifecycle as an imported dependency and updates the test to use linewidth.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 98.63% 98.55% -0.09%
==========================================
Files 35 35
Lines 5860 5866 +6
==========================================
+ Hits 5780 5781 +1
- Misses 80 85 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
approved these changes
Mar 10, 2026
Member
|
The failure on r-devel is unrelated (there is an issue with tiny differences in SVGs on r-devel). Merging now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #444, fixes #445
modify_aes_()which wrapped the deprecatedaes_()and was never called anywhere in the codebase.sizeparameter tolinewidthingrid_lines()andgrid_lines_y()to match ggplot2 3.4+ semantics (the value was already being passed aslinewidthinternally).mcmc_acf_barandmcmc_scatterthat usedsizewherelinewidthis expected.AI Usage Policy :
This issue was found using an LLM, but was solved without one!!