Fix deprecated formula syntax in aes() call#442
Merged
jgabry merged 1 commit intostan-dev:masterfrom Mar 10, 2026
Merged
Conversation
Replace `aes(x = ~ value)` with `aes(x = .data$value)` in the internal mcmc_hist/mcmc_dens code path. Fixes stan-dev#441
Member
|
We can merge this when the CI finishes |
Contributor
Author
great!! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 35 35
Lines 5860 5860
=======================================
Hits 5780 5780
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The one failure on r-devel is unrelated to this PR. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #441
Replaced
aes(x = ~ value)withaes(x = .data$value)inR/mcmc-distributions.R. This was the last remaining use of the deprecated formula syntax inaes().