Conversation
|
Thanks for the PR! I haven't had a chance to look at the code yet (I'm a bit swamped with work at the moment), but a couple quick comments:
|
|
@jgabry I fixed the error that popped up. Well the color "issue" can be resolved quite simply if we switch from "mid" to "light" for PPD, like PPC. |
@tjmahr Any preference on this? The first option would keep the code simpler, but it would change the appearance of all the PPD plots (could we call this breaking visual backwards compatibility?). I would lean towards the second option but I'm not really sure. |
|
I just tried using this branch and |
|
Sorry, it was only documented in |
Addresses #425
This PR adds the
show_marginalargument (defaultFALSE) to thePPD-distributionsand thePPD-test-statisticsfunctions (thePPD-intervalsfunctions de-facto show the marginal PPD(s)).I think we need a better default PPD color - which?
Here are all of these functions (default plots --
show_marginal=FALSE-- are unchanged!):ppd-distributions
ppd-test-statistics
Created on 2026-03-08 with reprex v2.1.1