Skip to content

feat(review): findings-only review contract; verdict derives approval - #189

Merged
SutuSebastian merged 2 commits into
mainfrom
agent/sta-452-s1
Nov 18, 2026
Merged

SutuSebastian merged 2 commits into
mainfrom
agent/sta-452-s1

Conversation

@SutuSebastian

Copy link
Copy Markdown
Contributor

Summary

review.json becomes a findings-only contract, and verdict derives approval. No model's approval bias reaches the gate any more. This is STA-452, S1 of STA-443 (see the spec doc "evidence-checked review handoff").

 review.json  (schema_version stays "1": breaking, in place, no shim)
-  approved, body, comments[], sections[], confidence(1-5)
+  findings[]: { path, line, severity, claim, quote, confidence: high|medium|low, …optional rigor/category/brief/suggestion/sources/kb }
+  spec_checks[]: { item, status: met|violated|n/a, evidence{path,line,quote} }   (S4 enforces)
+  receipts[]:    { hunk, quote }                                                 (S4 enforces)
+  summary (≤ 2000 characters)
record   checks, merges, derives approval ONCE (approval.Evaluate: default tier "important", block_clauses, violated spec checks;
         unverified findings never gate), stores the decision in record.json, and aligns the body's lead with it
post     publishes record.json's decision; refuses `record-stale` if head, diff or review changed since record
report   uses the same predicate for --check
body     a minimal deterministic renderer (the seam S3 replaces)
store    claim kept as `body` (sig stability), finder_confidence, quote, verification.quote = "unchecked" (S4 fills it)
  • Producers updated: pack test, the run/stage directive, the shipped prompts, the SDK/TS client, the self-review recipe.
  • basis-replaced is retired (the agent writes no body).
  • Suppressions: //nolint goes 798 → 773. The new enum lists live in the schemagen overlay, not in struct tags.

Evidence

  • Approval behavior (mutation-proved):
    • with no config, critical → not approved, important → not approved, informational only → approved;
    • a block clause withholds approval, and the rendered lead agrees;
    • a review edited after record → post refuses record-stale.
  • Old shape: a v1-shaped document fails the closed schema through the existing bad-review-input path. There is no v1 detector (pre-v1, no compat).
  • Restored or kept guards:
    • rigor-unset still warns;
    • summary is counted in runes;
    • an empty claim/quote is refused;
    • cost.json stays "2".
  • Review:
    • the orchestrator's design review plus a full contract review;
    • the two-finder verdict dogfood gate (hy4 plus DeepSeek, chunked): 9 important findings, all fixed. One was declined: the agent-mistake repairs (rung→rigor, file→path) stay, by design.
  • Builder ladder at 938bc6d1d, all exit 0:
    • make test-race
    • make evals (143 passed)
    • doc-coverage
    • make vet (native and Windows)
    • make deadcode
    • make cross
    • golangci-lint (native and Windows)
    • schemas-check
    • ts-types-check
    • clients-ts
    • make size
    • gofmt

Merge Danger

Door: two-way in code, but do not release this alone. Until S4 (STA-456) adds proof-of-reading receipts, a findings-free review derives approval. The changeset says so.

Blast Radius: review-contract. Every agent, prompt, SDK and fixture that writes review.json changes shape (333 files, mostly migrated fixtures and goldens). Binary size budgets moved one 10 kB step, with the measurements in the commit.

SutuSebastian and others added 2 commits November 19, 2026 00:05
`review.json` becomes a findings-only handoff inside `schema_version` `"1"`:
every finding carries `path`, a strict integer `line`, `severity`, `claim`,
`quote` and `confidence`, with optional `start_line`, `side`, `rigor`,
`category`, `suggestion`, `brief`, `sources` and `kb`. `spec_checks[]` and
`receipts[]` reserve the evidence the verifier slice will enforce, and
`summary` carries at most 2000 characters of prose.

- The document is closed. `approved`, `body`, `comments[]`, `sections[]` and a
  top-level `confidence` are no longer published, so an old file refuses
  through the ordinary unknown-field and missing-`findings` problems; there is
  no dedicated detector, repair hint or shim.
- Verdict renders the body from the findings: `claim` is stored as the finding
  body, `confidence` as `finder_confidence`, and every fresh finding records
  `verification.quote` as `unchecked`. `inBounds` is derived from the pinned
  hunks instead of being claimed.
- Approval is verdict-derived (`internal/core/approval`): any open, visible
  finding at `important` or above whose quote standing is not `unverified`
  withholds, as does a violated spec check. `record` decides once and stores
  the receipt in `record.json` beside the `review_sha256` it decided on, the
  rendered body's lead follows that same decision, and `post` publishes the
  stored decision instead of reading `review.approved` — refusing
  `record-stale` when the review, diff, or head moved after the record rather
  than deciding again over a review nobody recorded.
- New store fields: `FindingEntry.quote`/`finder_confidence`, a typed
  `verification` object, plus `approval`, `spec_checks` and `receipts` on the
  record. Additive for readers; the review input is the breaking half.
- The dry run's `data.check` counts `findings` and `anchors_moved_to_body`
  instead of the old `comments`/`sections` pair.
- `schemas/review.schema.json` is regenerated closed, the envelope carries the
  new definitions, and the TypeScript envelope types follow.
- No new `//nolint`: the store entry's `category`, `status` and `source`
  closed lists move to the schemagen overlay (the widest tag was widening the
  column past the line limit for seven neighbours), `Comment` and `SectionTag`
  go with `comments[]`/`sections[]`, and the review-complexity splits are
  structural. `Finding`, `SpecEvidence` and `ApprovalReceipt` order their
  fields the way the field-alignment analyzer requires, so the generated
  property order changes with no value, type, enum or required key moving.

- Size: darwin/amd64 17,827,744 B, darwin/arm64 16,220,546 B, linux/amd64
  17,518,752 B, linux/arm64 15,859,872 B, windows/amd64 17,914,368 B,
  windows/arm64 15,973,888 B. The ceilings hold at 17830000, 17520000,
  15870000, 17920000, 15980000; darwin/arm64 crossed its first line, so it
  moves one 10 kB step to 16230000.

Review of the first cut fixed four regressions it shipped: the sweep had
rewritten `cost.json`'s `schema_version` to `"1"` in `review.md` and
`PROCEDURE.md` (the cost record is `2`), left the agent-facing messages
naming the retired `{body, approved, comments[]}` shape, dropped the
`rigor-unset` warning for a finding with no rung, and let the self-review
recipe keep reading `comments` so its retry never fired — with the eval then
rewritten to assert the broken stop. The checker also now counts `summary`
in runes as the schema's `maxLength` does and refuses an empty `claim`,
`quote`, `spec_checks[].item` or receipt string, and the TS client fixtures
plus the bench loop fixtures write the findings shape.

Rebased onto #187's backtest fixtures (13 commits). Two conflicts: the
archtest core-subpackage list and facade allowlist needed `quality` from #187
alongside `approval` and `reviewdoc`, and `scripts/size-baseline.txt` keeps
main's ratchet as the base the numbers above move past.

Do not release this slice before S4 verifies quotes and receipt coverage.
@changeset-bot

changeset-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 883295b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stainless-code/verdict Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 349 files, which is 249 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

Usage-priced reviews support at most 300 files.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 46c47489-68e4-4baa-b099-1c0696610cab
Commits

Reviewing files that changed from the base of the PR and between 31fba99 and 883295b.

Files selected for processing: 349

  • .changeset/sta-452-findings-only-review.md
  • apps/docs/content/01-docs/(guides)/local-review.mdx
  • bench/corpus/auth-bypass/agents/fixture-good.json
  • bench/corpus/auth-bypass/agents/fixture-noisy.json
  • bench/corpus/control-comment/agents/fixture-good.json
  • bench/corpus/control-comment/agents/fixture-noisy.json
  • bench/corpus/control-rename/agents/fixture-good.json
  • bench/corpus/control-rename/agents/fixture-noisy.json
  • bench/corpus/missing-error-check/agents/fixture-good.json
  • bench/corpus/missing-error-check/agents/fixture-noisy.json
  • bench/corpus/nil-deref/agents/fixture-good.json
  • bench/corpus/nil-deref/agents/fixture-noisy.json
  • bench/corpus/off-by-one/agents/fixture-good.json
  • bench/corpus/off-by-one/agents/fixture-noisy.json
  • bench/corpus/panic-index/agents/fixture-good.json
  • bench/corpus/panic-index/agents/fixture-noisy.json
  • bench/corpus/path-traversal/agents/fixture-good.json
  • bench/corpus/path-traversal/agents/fixture-noisy.json
  • bench/corpus/race-close/agents/fixture-good.json
  • bench/corpus/race-close/agents/fixture-noisy.json
  • bench/corpus/sql-injection/agents/fixture-good.json
  • bench/corpus/sql-injection/agents/fixture-noisy.json
  • bench/runner/bench_test.go
  • bench/runner/endtoend_test.go
  • bench/runner/loop.go
  • bench/runner/loop_test.go
  • bench/runner/prompt.go
  • bench/runner/testdata/tool-free-prompt.golden
  • bench/runner/toolcontract_test.go
  • clients/ts/src/refusal-codes.gen.ts
  • clients/ts/src/types.gen.ts
  • clients/ts/test/client.test.mjs
  • cmd/verdict/stdout_contract_test.go
  • docs/ci-recipe.md
  • docs/manual.md
  • docs/recipes/self-review.py
  • docs/recipes/test_self_review.py
  • docs/troubleshooting.md
  • evals/README.md
  • evals/cases/automation-recipe.sh
  • evals/cases/backtest-replay.sh
  • evals/cases/backtest-score.sh
  • evals/cases/bench-corpus.sh
  • evals/cases/chaos-loop.sh
  • evals/cases/chaos-order.sh
  • evals/cases/chaos-stale.sh
  • evals/cases/chunk-coverage.sh
  • evals/cases/chunk-incremental.sh
  • evals/cases/chunk-synthesize.sh
  • evals/cases/coverage.sh
  • evals/cases/envelope-shape.sh
  • evals/cases/forgejo-post.sh
  • evals/cases/gitlab-fetch-post.sh
  • evals/cases/ignore-floor.sh
  • evals/cases/kb.sh
  • evals/cases/mcp-stdio.sh
  • evals/cases/panel.sh
  • evals/cases/post-go-guards.sh
  • evals/cases/prompt-dump-summary.sh
  • evals/cases/provenance.sh
  • evals/cases/publish-footer.sh
  • evals/cases/publish-overrides.sh
  • evals/cases/record-dry-run.sh
  • evals/cases/record-input-refusals.sh
  • evals/cases/record-normalize.sh
  • evals/cases/review-provenance.sh
  • evals/cases/schema-contract.sh
  • evals/cases/self-review.sh
  • evals/cases/terminal-write.sh
  • evals/cases/verify-allowlist.sh
  • evals/fixtures/run-agent/agent-stub.sh
  • evals/fixtures/run-agent/repair-stub.sh
  • evals/fixtures/self-review/agent.sh
  • evals/lib/common.sh
  • internal/adopt/golden_test.go
  • internal/archtest/imports_test.go
  • internal/archtest/problemcodes_test.go
  • internal/archtest/prompt_schema_test.go
  • internal/cli/refuse_test.go
  • internal/config/checks.go
  • internal/core/approval/approval.go
  • internal/core/approval/approval_test.go
  • internal/core/backtest/fakeagent_test.go
  • internal/core/backtest/replay_test.go
  • internal/core/corpus/corpus_test.go
  • internal/core/fetch/groupbudget_test.go
  • internal/core/fetch/impact_test.go
  • internal/core/hint.go
  • internal/core/pack/list_test.go
  • internal/core/pack/pack_test.go
  • internal/core/panel/apply.go
  • internal/core/panel/plan.go
  • internal/core/panel/plan_test.go
  • internal/core/panel/verdicts.go
  • internal/core/panelwire_test.go
  • internal/core/post/messages.go
  • internal/core/post/normalize_test.go
  • internal/core/post/recordstore.go
  • internal/core/post/recordstore_test.go
  • internal/core/post/runpolicy.go
  • internal/core/post/secretvalues.go
  • internal/core/post/secretvalues_test.go
  • internal/core/post/service.go
  • internal/core/post/service_test.go
  • internal/core/post/submit_contract_test.go
  • internal/core/query/query_test.go
  • internal/core/record/category_test.go
  • internal/core/record/checkreview.go
  • internal/core/record/checkreview_test.go
  • internal/core/record/dryrun_test.go
  • internal/core/record/extraction_test.go
  • internal/core/record/fields.go
  • internal/core/record/floor_test.go
  • internal/core/record/merge.go
  • internal/core/record/merge_anchor_test.go
  • internal/core/record/mergeapi.go
  • internal/core/record/messages.go
  • internal/core/record/normalize.go
  • internal/core/record/normalize_test.go
  • internal/core/record/risk_test.go
  • internal/core/record/service.go
  • internal/core/record/service_test.go
  • internal/core/record/store_contract_test.go
  • internal/core/record/suppression_test.go
  • internal/core/refusal.go
  • internal/core/refusalcodes.go
  • internal/core/repair/repair_test.go
  • internal/core/report/policy.go
  • internal/core/report/render.go
  • internal/core/report/report_test.go
  • internal/core/report/service.go
  • internal/core/reviewdoc/review.go
  • internal/core/reviewdoc/review_test.go
  • internal/core/run/prompt.go
  • internal/core/run/redact_internal_test.go
  • internal/core/run/repair_test.go
  • internal/core/run/service_internal_test.go
  • internal/core/skill/detect_test.go
  • internal/core/stores.go
  • internal/core/testdata/hints.golden
  • internal/core/testdata/record-panel-order.golden
  • internal/core/types.go
  • internal/core/verify/service_test.go
  • internal/fetch/testdata/author-advisory.golden
  • internal/fetch/testdata/azure-happy.golden
  • internal/fetch/testdata/base-sha-json.golden
  • internal/fetch/testdata/base-sha-note.golden
  • internal/fetch/testdata/bitbucket-happy.golden
  • internal/fetch/testdata/bitbucket-paging.golden
  • internal/fetch/testdata/budget-over-consented.golden
  • internal/fetch/testdata/budget-unknown.golden
  • internal/fetch/testdata/budget-unreadable.golden
  • internal/fetch/testdata/budget-unset.golden
  • internal/fetch/testdata/budget-within.golden
  • internal/fetch/testdata/cap-override-beats-chunk.golden
  • internal/fetch/testdata/cap-override.golden
  • internal/fetch/testdata/controls-base-absent.golden
  • internal/fetch/testdata/dump-json.golden
  • internal/fetch/testdata/dump-text.golden
  • internal/fetch/testdata/empty-diff.golden
  • internal/fetch/testdata/file-paging.golden
  • internal/fetch/testdata/forgejo-happy.golden
  • internal/fetch/testdata/gitcafe-base-note.golden
  • internal/fetch/testdata/gitcafe-happy.golden
  • internal/fetch/testdata/gitlab-base-note.golden
  • internal/fetch/testdata/gitlab-base.golden
  • internal/fetch/testdata/gitlab-happy.golden
  • internal/fetch/testdata/gitlab-text.golden
  • internal/fetch/testdata/happy-json.golden
  • internal/fetch/testdata/happy-text.golden
  • internal/fetch/testdata/local-branch.golden
  • internal/fetch/testdata/local-dump-chunk.golden
  • internal/fetch/testdata/local-dump-text.golden
  • internal/fetch/testdata/local-paths.golden
  • internal/fetch/testdata/local-range.golden
  • internal/fetch/testdata/local-range3.golden
  • internal/fetch/testdata/local-staged.golden
  • internal/fetch/testdata/local-stash.golden
  • internal/fetch/testdata/local-untracked.golden
  • internal/fetch/testdata/local-worktree-text.golden
  • internal/fetch/testdata/local-worktree.golden
  • internal/fetch/testdata/over-cap-chunk-text.golden
  • internal/fetch/testdata/over-cap-chunk.golden
  • internal/fetch/testdata/over-cap-knob.golden
  • internal/fetch/testdata/ratelimit-retry.golden
  • internal/fetch/testdata/sensitive-kb-head.golden
  • internal/fetch/testdata/sensitive-kb.golden
  • internal/fetch/testdata/since-alias.golden
  • internal/fetch/testdata/threads-degraded.golden
  • internal/mcp/mcp_test.go
  • internal/packtest/test.go
  • internal/packtest/test_test.go
  • internal/panel/panel_test.go
  • internal/promptkeys/promptkeys.go
  • internal/provenance/basis.go
  • internal/provenance/prompts_test.go
  • internal/provenance/provenance_test.go
  • internal/readcommon/context.go
  • internal/readcommon/context_test.go
  • internal/readgolden/golden_test.go
  • internal/readgolden/testdata/report/completeness-missing.golden
  • internal/readgolden/testdata/report/cost-json.golden
  • internal/readgolden/testdata/report/cost-unreadable.golden
  • internal/readgolden/testdata/report/json.golden
  • internal/readgolden/testdata/report/kind-section-json.golden
  • internal/readgolden/testdata/report/kitchen-sink.golden
  • internal/readgolden/testdata/report/local-check-json.golden
  • internal/record/golden_cases_test.go
  • internal/record/golden_refusals_test.go
  • internal/record/testdata/body/mermaid-stripped.golden
  • internal/record/testdata/body/non-ascii.golden
  • internal/record/testdata/body/receipt-collision.golden
  • internal/record/testdata/chunk/bad-schema.golden
  • internal/record/testdata/chunk/drift.golden
  • internal/record/testdata/chunk/malformed-attestation.golden
  • internal/record/testdata/chunk/partial.golden
  • internal/record/testdata/chunk/unattested.golden
  • internal/record/testdata/chunk/unknown-chunk-claim.golden
  • internal/record/testdata/chunk/valid.golden
  • internal/record/testdata/claims/bad-triage-status/rereview.golden
  • internal/record/testdata/claims/verify-triage-resolved/rereview.golden
  • internal/record/testdata/degenerate/bad-schema.golden
  • internal/record/testdata/degenerate/basis-ok.golden
  • internal/record/testdata/degenerate/blob-link-local.golden
  • internal/record/testdata/degenerate/brief-bad-outcome.golden
  • internal/record/testdata/degenerate/brief-invalid.golden
  • internal/record/testdata/degenerate/brief-valid.golden
  • internal/record/testdata/degenerate/carried-footer.golden
  • internal/record/testdata/degenerate/confidence-invalid.golden
  • internal/record/testdata/degenerate/confidence-valid.golden
  • internal/record/testdata/degenerate/empty-diff-finding.golden
  • internal/record/testdata/degenerate/false-anchors.golden
  • internal/record/testdata/degenerate/false-side.golden
  • internal/record/testdata/degenerate/fenced-suggestion.golden
  • internal/record/testdata/degenerate/finding-confidence-invalid.golden
  • internal/record/testdata/degenerate/finding-confidence-valid.golden
  • internal/record/testdata/degenerate/missing-findings.golden
  • internal/record/testdata/degenerate/missing-marker-ok.golden
  • internal/record/testdata/degenerate/normalized-fenced.golden
  • internal/record/testdata/degenerate/normalized-prose.golden
  • internal/record/testdata/degenerate/normalized-weak-shapes.golden
  • internal/record/testdata/degenerate/null-path.golden
  • internal/record/testdata/degenerate/short-body.golden
  • internal/record/testdata/degenerate/string-line.golden
  • internal/record/testdata/incremental/non-touching/rereview.golden
  • internal/record/testdata/incremental/reopen/rereview.golden
  • internal/record/testdata/kb/absent.golden
  • internal/record/testdata/kb/bad-id-shape.golden
  • internal/record/testdata/kb/bad-policy-env.golden
  • internal/record/testdata/kb/bad-shape.golden
  • internal/record/testdata/kb/broken-store.golden
  • internal/record/testdata/kb/counter-adds/rereview.golden
  • internal/record/testdata/kb/duplicate.golden
  • internal/record/testdata/kb/empty.golden
  • internal/record/testdata/kb/false-positive/rereview.golden
  • internal/record/testdata/kb/joins-idempotent/rereview.golden
  • internal/record/testdata/kb/malformed-id.golden
  • internal/record/testdata/kb/no-store.golden
  • internal/record/testdata/kb/null.golden
  • internal/record/testdata/kb/retired.golden
  • internal/record/testdata/kb/string-counters/rereview.golden
  • internal/record/testdata/kb/truncated.golden
  • internal/record/testdata/kb/unknown.golden
  • internal/record/testdata/kb/valid.golden
  • internal/record/testdata/legacy/backfill-passthrough/rereview.golden
  • internal/record/testdata/matrix/n10/first.golden
  • internal/record/testdata/matrix/n10/rereview.golden
  • internal/record/testdata/matrix/n200/first.golden
  • internal/record/testdata/matrix/n200/rereview.golden
  • internal/record/testdata/matrix/n50/first.golden
  • internal/record/testdata/matrix/n50/rereview.golden
  • internal/record/testdata/missing/bundle.golden
  • internal/record/testdata/missing/review.json.golden
  • internal/record/testdata/overrides/bad-placeholder.golden
  • internal/record/testdata/overrides/bad-threshold.golden
  • internal/record/testdata/overrides/dir-as-fragment.golden
  • internal/record/testdata/overrides/duplicate-footer.golden
  • internal/record/testdata/overrides/duplicate-threshold.golden
  • internal/record/testdata/overrides/eq-threshold.golden
  • internal/record/testdata/overrides/locked-marker.golden
  • internal/record/testdata/overrides/marker-fragment.golden
  • internal/record/testdata/overrides/multiline-attribution.golden
  • internal/record/testdata/overrides/unknown-field.golden
  • internal/record/testdata/overrides/valid.golden
  • internal/record/testdata/provider/gitlab.golden
  • internal/record/testdata/refuse/corrupt-review.golden
  • internal/record/testdata/refuse/empty-prior.golden
  • internal/record/testdata/refuse/false-prior.golden
  • internal/record/testdata/refuse/non-array-resolved.golden
  • internal/record/testdata/refuse/non-array-triage.golden
  • internal/record/testdata/refuse/non-array-verification.golden
  • internal/record/testdata/refuse/non-object-comment.golden
  • internal/record/testdata/refuse/non-object-finding.golden
  • internal/record/testdata/refuse/non-object-review.golden
  • internal/record/testdata/refuse/non-object-triage.golden
  • internal/record/testdata/refuse/non-object-verification.golden
  • internal/record/testdata/refuse/non-string-resolved.golden
  • internal/record/testdata/refuse/null-prior.golden
  • internal/record/testdata/refuse/numeric-body.golden
  • internal/record/testdata/refuse/numeric-claim.golden
  • internal/record/testdata/refuse/numeric-path.golden
  • internal/record/testdata/refuse/numeric-suggestion.golden
  • internal/record/testdata/refuse/object-path.golden
  • internal/record/testdata/refuse/true-suggestion.golden
  • internal/record/testdata/refuse/utf8-scrubbed-claim.golden
  • internal/record/testdata/source/dirty-head.golden
  • internal/record/testdata/source/dirty-string.golden
  • internal/record/testdata/source/garbage-provider.golden
  • internal/record/testdata/uncite/absent-keeps/rereview.golden
  • internal/record/testdata/uncite/explicit-clears/rereview.golden
  • internal/record/testdata/uncite/malformed-clears/rereview.golden
  • internal/record/testdata/uncite/null-keeps/rereview.golden
  • internal/record/testdata/verify/ambiguous-prefix/rereview.golden
  • internal/record/testdata/verify/bad-head/rereview.golden
  • internal/record/testdata/verify/contradict-exit/rereview.golden
  • internal/record/testdata/verify/contradict-timeout/rereview.golden
  • internal/record/testdata/verify/empty-cmd/rereview.golden
  • internal/record/testdata/verify/inconclusive/rereview.golden
  • internal/record/testdata/verify/on-addressed/rereview.golden
  • internal/run/run_unix_test.go
  • internal/schemagen/build.go
  • internal/schemagen/conformance_brief_test.go
  • internal/schemagen/conformance_record_test.go
  • internal/schemagen/conformance_test.go
  • internal/schemagen/model.go
  • internal/schemagen/overlay.go
  • internal/schemagen/overlay.json
  • internal/schemagen/overlay_test.go
  • internal/schemagen/semantics_test.go
  • internal/schemagen/testdata/baseline/envelope.schema.json
  • internal/schemagen/testdata/baseline/findings.schema.json
  • internal/schemagen/testdata/baseline/post.schema.json
  • internal/schemagen/testdata/baseline/record.schema.json
  • internal/schemagen/testdata/baseline/review.schema.json
  • internal/serve/serve_test.go
  • internal/testenv/review.go
  • pkg/verdict/check_example_test.go
  • pkg/verdict/example_test.go
  • pkg/verdict/normalize_example_test.go
  • pkg/verdict/sdk_flags_test.go
  • procedure/PROCEDURE.md
  • procedure/prompts/incremental-review.md
  • procedure/prompts/review.md
  • schemas/envelope.schema.json
  • schemas/findings.schema.json
  • schemas/post.schema.json
  • schemas/record.schema.json
  • schemas/review.schema.json
  • scripts/size-baseline.txt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@SutuSebastian
SutuSebastian merged commit 160c288 into main Nov 18, 2026
21 checks passed
@SutuSebastian
SutuSebastian deleted the agent/sta-452-s1 branch November 18, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant