Repository navigation
list-conforma-*: add --scenario flag for acs-conforma-prod-like - #114
Open
tommartensen wants to merge 1 commit into
Open
tommartensen wants to merge 1 commit into
tommartensen wants to merge 1 commit into
Conversation
Both commands accept --scenario (default acs-conforma-dev, alternatively acs-conforma-prod-like, only supported for the stackrox repository). The dev scenario keeps the pipelines-as-code discovery on the tag's commit. The prod-like scenario finds the custom snapshot for the tag, derives the versioned scenario name from the snapshot's application label and lists the conforma pipeline runs attached to the snapshot; the violations command applies the existing per-run logic to those runs. Unknown scenario values and prod-like for non-stackrox repositories error out. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #113 (
tm/redo-conforma-commands).list-conforma-runsandlist-conforma-violationscurrently only cover theacs-conforma-devpolicy: they discover PipelineRuns via pipelines-as-code labels on the tag's commit, so theacs-conforma-prod-likeruns attached to the custom snapshot are invisible to them.This PR adds a
--scenarioflag to both commands:acs-conforma-dev(default) — unchanged: conforma runs triggered directly on the tag's commit via pipelines-as-code.acs-conforma-prod-like(only supported for thestackroxrepository, otherwise the command errors) — snapshot-based flow:appstudio.openshift.io/applicationlabel (e.g.acs-conforma-prod-like-4-10; nightly → unversioned),appstudio.openshift.io/snapshot+ scenario labels).list-conforma-runsoutputs these;list-conforma-violationsfeeds them into the same per-run logic as the dev flow (latest run per component+scenario, in-progress detection, report parsing).The per-run violations logic was extracted into
violationsFromPipelineRunsso both scenarios share it.Testing
go build ./...,go vet ./...,go test ./...pass🤖 Generated with Claude Code