Skip to content

Use roxie for deployment in CI - #520

Merged
mclasmeier merged 1 commit into
masterfrom
mc/migrate-to-roxie
Nov 10, 2026
Merged

mclasmeier merged 1 commit into
masterfrom
mc/migrate-to-roxie

Conversation

@mclasmeier

@mclasmeier mclasmeier commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace legacy deploy-local.sh with roxie deploy central for StackRox deployment in CI
  • Parameterize certificate setup and test endpoint using roxie's envrc outputs (ROX_ENDPOINT, ROX_CENTRAL_HOST, ROX_CENTRAL_PORT, ROX_INTERNAL_CENTRAL_NAME) instead of hardcoded values
  • Update set-certificates.sh to accept host/port/IP from environment variables with backwards-compatible defaults

Test plan

  • CI workflow runs successfully with roxie-based deployment
  • set-certificates.sh correctly imports Central's TLS certs into the JVM truststore
  • Functional tests connect to the dynamically resolved Central endpoint

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Automated test runs now use a deployed Central instance and its assigned connection details.
    • Certificate setup uses configurable Central host, port, and IP values, while retaining defaults.
    • Test runs wait for Central to become ready, with a longer startup window. These updates affect the test environment only; no user-facing product behavior has changed.

The test workflow now uses roxie to deploy Central and exports deployment credentials and endpoint settings. The test endpoint and certificate setup use those settings, with defaults retained for certificate values.

Changes: Central test setup

Layer / File(s) Summary
Central deployment and environment export
.github/workflows/tests.yaml
The workflow checks out StackRox with full history and tags, installs roxie v0.4.17, and uses it to deploy Central. It sources the generated environment file and exports credentials and endpoint settings.
Test connection and certificate settings
.github/workflows/tests.yaml, scripts/set-certificates.sh
The test endpoint uses the configured internal hostname and exported port. Certificate setup reads HOST, PORT, and IP from environment variables and retains the previous defaults.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: Minimal · up to ae1d2

The deployment retains readiness waiting and supplies a numeric address for certificate setup. No actionable merge-blocking issue remains; merge after normal checks pass.

Pre-merge checks: Passed 5

Check name Status Explanation
Description check Passed The description has a Summary section and a Test plan section. It lists the replacement of deploy-local.sh with roxie deploy central, the parameterization of certificate setup and test endpoint, and t…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: replacing the legacy CI deployment with roxie.
Full details: Description check

Explanation

The description has a Summary section and a Test plan section. It lists the replacement of deploy-local.sh with roxie deploy central, the parameterization of certificate setup and test endpoint, and the backward-compatible defaults in set-certificates.sh. The template only asks for a brief description of changes and labels. The description does not state which label to apply (enhancement, bug, chore, or dependencies), so the labeling reminder from the template is not addressed. This gap is minor and does not make the description largely incomplete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b455b2a5-8352-4a5d-b6d8-9d53bb3fb6a5
Commits

Reviewing files that changed from the base of the PR and between e80fc68 and ae1d2b3.

Files selected for processing: 2

  • .github/workflows/tests.yaml
  • scripts/set-certificates.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@mclasmeier
mclasmeier force-pushed the mc/migrate-to-roxie branch 4 times, most recently from 498a17c to e4cbd8c Compare November 5, 2026 14:13
@mclasmeier

Copy link
Copy Markdown
Contributor Author

@coderabbitai, care to review this one?

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

@mclasmeier I’ll review this PR, focusing on the roxie deployment, environment variables, certificate setup, and functional test endpoint.

Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mclasmeier mclasmeier changed the title Migrate to deployment with roxie Use roxie for deployment in CI Nov 5, 2026
@mclasmeier
mclasmeier merged commit ad42508 into master Nov 10, 2026
5 checks passed
@mclasmeier
mclasmeier deleted the mc/migrate-to-roxie branch November 10, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants