feat(manifest): add per-file digest provenance - #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #84.
input_file_digestsandconfig_file_digeststo current run manifests.input_digestandconfig_digestalgorithms and all six v1.2 aggregate values.run-manifest/v1schema frozen and version the new shape asrun-manifest/v2.demos/<demo>/...identities and external window inputs explicitexternal/input/...orexternal/config/...identities, without local path leakage.Design decision
The legacy aggregate contract remains label-sorted and LF/CRLF-normalized for UTF-8 text. Per-file digests use exact raw bytes. Aggregate and per-file maps must reference the same resolved file set, and each distinct file is read once so both contracts derive from one byte snapshot.
Because the published v1 schema has
additionalProperties: false, the new fields are not honestly additive for strict v1 validators. The v1 schema remains unchanged atschemas/run_manifest.schema.json; current writers identify and validate againstschemas/run_manifest.v2.schema.json.Main risk
This is an intentional manifest schema-version transition: consumers pinned to v1 must select the v2 schema before consuming current manifests. The LF checkout contract renormalizes four historical CRLF/mixed tracked input/config files and one generated report at the Git blob boundary. All five were confirmed content-identical when EOL differences are ignored.
Compatibility impact
core.autocrlf=true.Rollback path
Revert the PR merge commit to restore v1 writers and artifacts. Consumers can continue validating retained v1 manifests with the frozen v1 schema. If the LF checkout contract is reverted independently, regenerate manifests against the chosen shipped-byte contract before publication.
Validation
python scripts/check_release_contract.py— 29 committed artifacts matched, 6 visual snapshots smoke-generated, 8 schema tests passed, 202 full tests passed.7bc939f— the same release gate passed; six manifests were independently rehashed withread_bytes(); tracked worktree remained clean after the gate.