Fix operator RBAC for event recording#5243
Open
pl4nty wants to merge 3 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/pl4nty/toolhive/sessions/91c560a3-ef9f-42db-82be-d6fceeadeff7 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pl4nty <21111317+pl4nty@users.noreply.github.com>
ChrisJBurns
previously approved these changes
May 11, 2026
Collaborator
|
@pl4nty Thanks for the PR, you'll need to run the helm-docs / pre-commit commands locally to make sure that the docs are all updated with the updated vaues.yaml file |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5243 +/- ##
==========================================
+ Coverage 67.99% 68.03% +0.04%
==========================================
Files 615 616 +1
Lines 63019 63005 -14
==========================================
+ Hits 42848 42865 +17
+ Misses 16965 16934 -31
Partials 3206 3206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tom Plant <tom@tplant.com.au>
Author
|
Thanks, fixed! Also noticed I didn't run all the e2e tests, so I've fixed those up too |
Contributor
|
I approved the CI workflows so that the PR runs through tests but you'll want to rebase @pl4nty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix operator RBAC for event recording, after controller-runtime breaking change in #4183. Noticed in errors like
Type of change
Test plan
task test)task test-e2e)task lint-fix)API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Does this introduce a user-facing change?
No
Implementation plan
Agent-Logs-Url: https://github.com/pl4nty/toolhive/sessions/91c560a3-ef9f-42db-82be-d6fceeadeff7
Special notes for reviewers