Fix: Align OpenAPI Type for Auth Timeout#4354
Open
Sanskarzz wants to merge 1 commit intostacklok:mainfrom
Open
Fix: Align OpenAPI Type for Auth Timeout#4354Sanskarzz wants to merge 1 commit intostacklok:mainfrom
Sanskarzz wants to merge 1 commit intostacklok:mainfrom
Conversation
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4354 +/- ##
==========================================
- Coverage 68.45% 68.39% -0.07%
==========================================
Files 479 479
Lines 48642 48642
==========================================
- Hits 33300 33268 -32
- Misses 12373 12406 +33
+ Partials 2969 2968 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
swaggertypetag for theTimeoutfield inpkg/auth/remote/config.go.This change was originally part of PR #4314 but was requested to be split into its own PR to keep the main feature PR focused on the validating webhook middleware.
Fix: #4353
Changes Included
pkg/auth/remote/config.goto useswaggertype:"primitive,integer"for theTimeoutfield.docs/server/docs.go,docs/server/swagger.json, anddocs/server/swagger.yamlaccordingly.Verification
task docsto confirm no unwanted schema bloat fortime.Duration../cmd/help/verify.sh.