Add AuthServerConfig validation condition to VirtualMCPServer reconciler#4350
Draft
jhrozek wants to merge 3 commits intovmcp-add-as-scaffolding-3from
Draft
Add AuthServerConfig validation condition to VirtualMCPServer reconciler#4350jhrozek wants to merge 3 commits intovmcp-add-as-scaffolding-3from
jhrozek wants to merge 3 commits intovmcp-add-as-scaffolding-3from
Conversation
Phase 2 of the vMCP embedded authorization server (#4141): - Add RegisterHandlers(mux) to EmbeddedAuthServer — the AS owns its route paths (/oauth/, /.well-known/openid-configuration, etc.) - Add AuthServer field to vMCP server Config - Replace /.well-known/ catch-all with explicit registrations: /.well-known/oauth-protected-resource (exact + subpath) is always registered; Mode B conditionally adds AS discovery/JWKS routes - No commands.go changes — CLI path deferred to Phase 4 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add StrategyTypeUpstreamInject and UpstreamInjectConfig to backend auth strategy types. Add ValidateAuthServerIntegration with cross-cutting validation rules (V-01 through V-07) that accept (*Config, *RunConfig) as separate arguments rather than a combined RuntimeConfig type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add RuntimeConfig and AuthServerConfig wrapper types to config model (runtime-only, not part of CRD schema) - Set AuthServerConfigValidated condition in reconciler when inline AuthServerConfig is present on the spec - Add E2E test for AuthServerConfigValidated condition lifecycle Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vmcp-add-as-scaffolding-3 #4350 +/- ##
=============================================================
- Coverage 69.32% 69.24% -0.08%
=============================================================
Files 479 479
Lines 48571 48579 +8
=============================================================
- Hits 33671 33640 -31
- Misses 12302 12339 +37
- Partials 2598 2600 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgrunnagle
approved these changes
Mar 24, 2026
jhrozek
force-pushed
the
vmcp-add-as-scaffolding-3
branch
from
d447384 to
39a9a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthServerConfig, the operator should validate it during reconciliation and surface the result as a status condition.AuthServerConfigValidatedcondition to the VirtualMCPServer reconciler that is set when inline AuthServerConfig is present on the spec.SetAuthServerConfigValidatedConditionto the status collector interface.Fixes: #4143
Type of change
Test plan
task test)task lint-fix)virtualmcp_authserver_config_test.go)Special notes for reviewers
Draft — stacked on #4349. Review the incremental diff only.
Generated with Claude Code