Skip to content

Remove SessionCacheSize from ScalingConfig#4347

Open
yrobla wants to merge 1 commit intomainfrom
drop_cache_size
Open

Remove SessionCacheSize from ScalingConfig#4347
yrobla wants to merge 1 commit intomainfrom
drop_cache_size

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Mar 24, 2026

Summary

The local LRU session cache layer was dropped in favour of going directly to Redis for session storage, making SessionCacheSize meaningless. Remove the field from ScalingConfig, clean up its tests, and update the generated Swagger docs.

Type of change

  • Bug fix
  • New feature
  • Refactoring (no behavior change)
  • Dependency update
  • Documentation
  • Other (describe):

Test plan

  • Unit tests (task test)
  • E2E tests (task test-e2e)
  • Linting (task lint-fix)
  • Manual testing (describe below)

Changes

File Change

Does this introduce a user-facing change?

Special notes for reviewers

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 24, 2026
@yrobla yrobla requested review from Copilot and jerm-dro March 24, 2026 15:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-obsolete SessionCacheSize knob from ScalingConfig after the local LRU session cache was removed in favor of Redis-backed session storage, and updates tests + generated Swagger artifacts accordingly.

Changes:

  • Remove SessionCacheSize from pkg/runner’s ScalingConfig.
  • Update run config serialization tests to only cover backend_replicas behavior.
  • Regenerate/update Swagger docs to drop session_cache_size from the API schema.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/runner/config.go Removes SessionCacheSize from ScalingConfig.
pkg/runner/config_test.go Updates round-trip JSON/YAML tests to stop asserting session_cache_size.
docs/server/swagger.yaml Removes session_cache_size from the OpenAPI schema.
docs/server/swagger.json Removes session_cache_size from the OpenAPI schema JSON output.
docs/server/docs.go Updates the embedded OpenAPI JSON template to remove session_cache_size.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.76%. Comparing base (ccb98c3) to head (d0363c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4347      +/-   ##
==========================================
- Coverage   68.95%   68.76%   -0.20%     
==========================================
  Files         479      479              
  Lines       48489    48506      +17     
==========================================
- Hits        33438    33356      -82     
- Misses      12317    12344      +27     
- Partials     2734     2806      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The local LRU session cache layer was dropped in favour of going
directly to Redis for session storage, making SessionCacheSize
meaningless. Remove the field from ScalingConfig, clean up its
tests, and update the generated Swagger docs.
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Mar 24, 2026
@yrobla yrobla requested a review from Copilot March 24, 2026 15:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants