Conversation
There was a problem hiding this comment.
Pull request overview
Removes the now-obsolete SessionCacheSize knob from ScalingConfig after the local LRU session cache was removed in favor of Redis-backed session storage, and updates tests + generated Swagger artifacts accordingly.
Changes:
- Remove
SessionCacheSizefrompkg/runner’sScalingConfig. - Update run config serialization tests to only cover
backend_replicasbehavior. - Regenerate/update Swagger docs to drop
session_cache_sizefrom the API schema.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/runner/config.go | Removes SessionCacheSize from ScalingConfig. |
| pkg/runner/config_test.go | Updates round-trip JSON/YAML tests to stop asserting session_cache_size. |
| docs/server/swagger.yaml | Removes session_cache_size from the OpenAPI schema. |
| docs/server/swagger.json | Removes session_cache_size from the OpenAPI schema JSON output. |
| docs/server/docs.go | Updates the embedded OpenAPI JSON template to remove session_cache_size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4347 +/- ##
==========================================
- Coverage 68.95% 68.76% -0.20%
==========================================
Files 479 479
Lines 48489 48506 +17
==========================================
- Hits 33438 33356 -82
- Misses 12317 12344 +27
- Partials 2734 2806 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The local LRU session cache layer was dropped in favour of going directly to Redis for session storage, making SessionCacheSize meaningless. Remove the field from ScalingConfig, clean up its tests, and update the generated Swagger docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
The local LRU session cache layer was dropped in favour of going directly to Redis for session storage, making SessionCacheSize meaningless. Remove the field from ScalingConfig, clean up its tests, and update the generated Swagger docs.
Type of change
Test plan
task test)task test-e2e)task lint-fix)Changes
Does this introduce a user-facing change?
Special notes for reviewers