RFC: Scoped secret store for system-managed tokens#56
Merged
Conversation
ChrisJBurns
reviewed
Mar 17, 2026
Open
11 tasks
ChrisJBurns
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thv secret listand vulnerable to accidental deletion. This RFC proposes isolating them under a reservedthv_sys/<scope>/prefix using newScopedProviderandUserProviderwrappers. This is also a prerequisite for enterprise CLI/Desktop login (stacklok-enterprise-platform#69).ScopedProviderandUserProviderwrapper design, named scopes (registry,workloads,auth), factory helpers, caller migration plan, and a key migration strategy for existing installations.Type of change
Test plan
Generated with Claude Code