Skip to content

[Implementation] Quiet benign guardrail notices - #1958

Open
aponcedeleonch wants to merge 4 commits into
plan/quiet-benign-hook-noticesfrom
impl/quiet-benign-hook-notices
Open

aponcedeleonch wants to merge 4 commits into
plan/quiet-benign-hook-noticesfrom
impl/quiet-benign-hook-notices

Conversation

@aponcedeleonch

@aponcedeleonch aponcedeleonch commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Summary

Make routine successful contextual guardrail inspections quiet by default in mecatui while preserving actionable outcomes.

  • classify only exact structured complete + acceptable + (execute | release_result) reviews with valid review identity/job as benign
  • retain benign hook summaries and live detail blocks, hiding them only in collapsed presentation
  • reveal retained benign notices with ctrl+t
  • add client setting hook_notices.show_benign: true
  • bind asynchronous details to the requesting session and review ID; stale responses are discarded and mismatches fail visibly
  • keep approval details isolated on their matching approval surface

Stack

Verification

Passed:

  • focused mecatui, client, and UI tests
  • changed-package race tests
  • task lint
  • task docs
  • task site:build
  • task ac-trace-strict
  • offline mecademo
  • panel review; all findings addressed

Known unrelated baseline failure:

  • task test and task test:race reproduce TestMecak8sHelmChart_DeployCheckProductionFixtureRuntimeAndSpread: rendered namespace is toolhive-system, while the existing fixture expects default. This stack does not modify Helm files.

@aponcedeleonch
aponcedeleonch added this pull request to stack #1959 September 26, 2026 06:55
@aponcedeleonch aponcedeleonch changed the title impl/quiet benign hook notices [Implementation] Quiet benign guardrail notices Sep 26, 2026
aponcedeleonch and others added 3 commits September 26, 2026 10:36
Co-Authored-By: mecatl <noreply@mecatl.dev>
Co-Authored-By: mecatl <noreply@mecatl.dev>
Co-Authored-By: mecatl <noreply@mecatl.dev>
Co-Authored-By: mecatl <noreply@mecatl.dev>
@aponcedeleonch
aponcedeleonch force-pushed the impl/quiet-benign-hook-notices branch from ec3f4d1 to 3902c08 Compare September 27, 2026 16:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants