Fix legacy ref files showing as orphans in cache list#52
Merged
Conversation
Legacy-format ref files (written by v0.0.24, digest-only) were not recognized by buildRefMap(), causing List() to report them as orphans and gc --dry-run to incorrectly claim they would be deleted (while actual GC via liveDigests() correctly preserved them). Two fixes: - LookupRef now upgrades legacy refs to extended format on cache hit - buildRefMap now marks legacy refs as referenced with a placeholder Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildRefMap(), causingList()to report entries as(orphan)andgc --dry-runto incorrectly claim they would be deleted — while actualGC()vialiveDigests()correctly preserved themLookupRef()now self-heals by upgrading legacy refs to extended format (imageRef\tdigest) on cache hitbuildRefMap()now marks legacy refs as referenced with a(unknown image)placeholder until upgradedTest plan
TestLookupRef_UpgradesLegacyReftest verifies self-healing upgrade-race🤖 Generated with Claude Code