Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions .github/workflows/upstream-release-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1019,20 +1019,10 @@ jobs:
# Per-user attempts sidestep both issues: the authoritative
# answer is "does GitHub accept this as a reviewer right now"
# and we ask the API that question directly.
#
# Cap attempts at 5 to avoid review fatigue on big releases.
TRIED=0
ASSIGN_LIST=""
MENTION_LIST=""
while IFS= read -r login; do
[ -z "$login" ] && continue
if [ "$TRIED" -ge 5 ]; then
# Over the review-fatigue cap -- mention any additional
# contributors instead of trying to assign them.
MENTION_LIST="${MENTION_LIST:+$MENTION_LIST }@$login"
continue
fi
TRIED=$((TRIED + 1))
if gh pr edit "$PR_NUMBER" --add-reviewer "$login" 2>/dev/null; then
ASSIGN_LIST="${ASSIGN_LIST:+$ASSIGN_LIST,}$login"
echo "Assigned: $login"
Expand All @@ -1049,7 +1039,7 @@ jobs:
{
echo "mention_block<<MENTION_EOF"
if [ -n "$MENTION_LIST" ]; then
echo "Release contributors we couldn't auto-assign as reviewers (review fatigue cap or GitHub rejected the assignment). Mentioning them so they see the PR documenting their work:"
echo "Release contributors we couldn't auto-assign as reviewers (GitHub rejected the assignment). Mentioning them so they see the PR documenting their work:"
echo ""
Comment on lines 1041 to 1043
echo "$MENTION_LIST"
fi
Expand Down