Repository navigation
Fix intermittent thv install failures in visual tests - #1354
Merged
Merged
Conversation
Anonymous GitHub API calls share a 60/hour per-IP limit that CI runners exhaust, which failed the visual regression job intermittently. Send GITHUB_TOKEN when it's set. The fetch error was also invisible: curl -s hid the HTTP status, and the fallback message was captured by the command substitution instead of reaching the log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Read the CLI version from the toolhive entry in .github/upstream-projects.yaml instead of a hardcoded 0.49.0 pin, so it moves with release sync PRs. Pass the job token to the install step to avoid API rate limits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking the installer and visual-test workflow changes.
No open issues 🎉
What changed in this PR
This PR addresses intermittent ToolHive CLI installation failures in visual tests by authenticating release metadata requests and improving error reporting. It also aligns visual-test CLI versions with the documentation’s upstream release configuration.
Changes:
- Use
GITHUB_TOKENfor release metadata requests when available. - Report curl errors and the failing API URL to stderr.
- Replace hardcoded CLI versions in both visual workflows with the version from
.github/upstream-projects.yaml.
| File | Description |
|---|---|
scripts/install-thv.sh |
Adds optional API authentication and visible fetch-failure diagnostics. |
.github/workflows/update-visual-baselines.yaml |
Passes the token and reads the configured ToolHive version for baseline generation. |
.github/workflows/_visual-regression.yaml |
Passes the token and reads the same version for visual comparisons. |
Review effort: Balanced
danbarr
enabled auto-merge (squash)
November 17, 2026 19:23
rdimitrov
approved these changes
Nov 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The visual regression job has been failing intermittently on the Install ToolHive CLI step (for example, #1353's run).
scripts/install-thv.shexited after about 0.2s with no output, so the failure wasn't diagnosable from the log.The likely cause is GitHub API rate limiting. The script fetched release metadata without authentication, and anonymous requests share a 60-per-hour limit per IP, which hosted runners regularly use up. Which runner a job landed on decided whether it passed. The error was silent because
curl -shid the HTTP status, and the fallback message was captured by the command substitution instead of reaching the log.Changes:
install-thv.shsendsGITHUB_TOKENas a bearer token when it's set. Vercel and local runs without a token behave as before.0.49.0. They read the version from thetoolhiveentry in.github/upstream-projects.yaml(currentlyv0.66.0), so the CLI used for snapshots moves with release sync PRs instead of drifting.The context7 metadata block is masked in its snapshot. If v0.66.0's
thv registry infooutput has a different number of lines than v0.49.0's, the page height changes and this PR's visual check needs a/update-snapshots.Type of change
Related issues/PRs
Intermittent failures on #1353 and on the
add-policy-webhook-docsbranch.🤖 Generated with Claude Code