Skip to content

Bound Helm description overrides by release - #1350

Merged
danbarr merged 1 commit into
mainfrom
fix-sep-v028-helm-overrides
Nov 16, 2026
Merged

danbarr merged 1 commit into
mainfrom
fix-sep-v028-helm-overrides

Conversation

@danbarr

@danbarr danbarr commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The v0.28.0 reference export fails because the v0.26.0 Workspace description overrides still apply after workspace.postgres.enabled is removed. Restrict those overrides to v0.26.x, and supply the two missing generative UI descriptions for v0.27.0 and v0.28.0. Release overrides support an exclusive before bound so the workaround expires at v0.28.1 and later releases use chart descriptions directly.

The old overrides remain available for regenerating v0.26.x references. The permanent chart annotations and PR-check failure propagation fix are tracked in https://github.com/stacklok/stacklok-enterprise-platform/pull/6759.

Type of change

  • Bug fix (release reference generation)

Validation

  • All 49 upstream-release tests passed, including override start and expiry boundaries.
  • Helm description validation passed for all eight charts at each of v0.26.0, v0.27.0, and v0.28.0 with helm-docs 1.14.2.
  • Production build, ESLint for changed scripts, and Prettier passed.

Related issues/PRs

Submitter checklist

Content and formatting

  • I have reviewed the content for technical accuracy
  • I have reviewed the content for spelling, grammar, and style

Reviewer checklist

Content

  • I have reviewed the content for technical accuracy
  • I have reviewed the content for spelling, grammar, and style

Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 21:22
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs-website Ready Ready Preview Nov 16, 2026 9:24pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The private SEP chart source and linked workflow runs returned 404, so a reviewer with SEP access must verify override fields, release bounds, and post-expiry chart coverage.

No open issues 🎉

What changed in this PR

This PR limits Helm description overrides to the releases that need them, preventing obsolete Workspace overrides from blocking reference generation for v0.28.0.

Changes:

  • Add an exclusive before bound to release-specific overrides.
  • Restrict existing Workspace overrides to v0.26.x and add temporary generative UI descriptions for releases from v0.27.0 through v0.28.0.
  • Extend tests to cover override activation and expiry boundaries.
File Description
scripts/​upstream-release/​generate-helm-reference.test.mjs Adds release-boundary cases and checks override selection.
scripts/​upstream-release/​generate-helm-reference.mjs Filters release overrides using the exclusive before bound.
.github/​upstream-projects.yaml Bounds Workspace overrides and supplies temporary generative UI descriptions.

Review effort: Balanced

@danbarr
danbarr merged commit 554fa0d into main Nov 16, 2026
8 checks passed
@danbarr
danbarr deleted the fix-sep-v028-helm-overrides branch November 16, 2026 21:27

This branch was successfully deployed

1 active deployment
Preview — 0e92dd59 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants