Repository navigation
Bound Helm description overrides by release - #1350
Merged
Merged
Conversation
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The private SEP chart source and linked workflow runs returned 404, so a reviewer with SEP access must verify override fields, release bounds, and post-expiry chart coverage.
No open issues 🎉
What changed in this PR
This PR limits Helm description overrides to the releases that need them, preventing obsolete Workspace overrides from blocking reference generation for v0.28.0.
Changes:
- Add an exclusive
beforebound to release-specific overrides. - Restrict existing Workspace overrides to v0.26.x and add temporary generative UI descriptions for releases from v0.27.0 through v0.28.0.
- Extend tests to cover override activation and expiry boundaries.
| File | Description |
|---|---|
scripts/upstream-release/generate-helm-reference.test.mjs |
Adds release-boundary cases and checks override selection. |
scripts/upstream-release/generate-helm-reference.mjs |
Filters release overrides using the exclusive before bound. |
.github/upstream-projects.yaml |
Bounds Workspace overrides and supplies temporary generative UI descriptions. |
Review effort: Balanced
peppescg
approved these changes
Nov 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v0.28.0 reference export fails because the v0.26.0 Workspace description overrides still apply after
workspace.postgres.enabledis removed. Restrict those overrides to v0.26.x, and supply the two missing generative UI descriptions for v0.27.0 and v0.28.0. Release overrides support an exclusivebeforebound so the workaround expires at v0.28.1 and later releases use chart descriptions directly.The old overrides remain available for regenerating v0.26.x references. The permanent chart annotations and PR-check failure propagation fix are tracked in https://github.com/stacklok/stacklok-enterprise-platform/pull/6759.
Type of change
Validation
Related issues/PRs
Submitter checklist
Content and formatting
Reviewer checklist
Content