Repository navigation
Update stacklok/toolhive to v0.65.0 - #1332
Conversation
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Generating docs for |
Claude generation reportSession status: success · Workflow run I updated the v0.65.0 docs and the site builds cleanly. The edits are formatted and linted but not committed; I left that to the later workflow step. What I changed:
What I didn't document, and why:
Files for the workflow:
The upstream clone wasn't readable from this session, so I verified against source at the tag with |
Claude editorial review reportSession status: success · Workflow run I reviewed the release docs and fixed one thing: a troubleshooting tip in What I reviewed: The HEAD commit only touches generated files you told me not to edit (Helm reference pages and
Fact checks: I couldn't read the local upstream clone (access was blocked), so I checked against the upstream repo with
The fix: The troubleshooting row for HTTP 401
This matches the page's body text. Nothing else in the three pages needed changing. I found no other pages that still describe the assertion time limits. I ran |
|
Done · 81 turns · $2.55 · run · see PR body for details |
|
Caution Docs augmentation failed. Run log. |
|
Generating docs for |
Claude generation reportSession status: success · Workflow run I updated the docs for ToolHive v0.65.0 but couldn't commit. The Doc changes:
Left undocumented (recorded in SUMMARY.md):
Artifacts at the repo root:
|
Claude editorial review reportSession status: success · Workflow run I reviewed the six docs pages changed for the toolhive v0.65.0 release and made one round of fixes, all in The commit at HEAD changed only auto-generated files (the Helm reference pages and
Fixes in the new "Authenticate workloads with SPIFFE SVIDs" section:
Claims I checked: I compared the SPIFFE claims against the merged upstream PR (stacklok/toolhive#7092). They match: only the I couldn't find the issuer-port warning in that PR's description, and I couldn't search the local upstream clone because it's outside the directories this session can read. Fixes 1 and 2 rely on the earlier session's wording for that warning. The 60-second clock-skew numbers and the new token-only wording in The other pages needed no changes: the audit-log trace and span ID fields, the CIMD rule that keeps serving an expired document while the refresh fails, the new row in the "Choose a way to get a token" table, and removing the old |
|
Done · 101 turns · $7.42 · run · see PR body for details |
SPIFFE clients can exchange subject tokens from a trusted external issuer, not only from ToolHive. The delegate agent identity guide described only the ToolHive-issued case, so readers configuring an external issuer had no guidance on the policy fields needed. Describe both cases, link to the issuer policy setup, and warn that allowedDelegateClients set to ["*"] admits every SPIFFE client. Update the embedded auth server pattern table to match. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
Pushed a docs commit (66ed7bc) on top of this branch. What changed: the delegate agent identity guide only described SPIFFE clients exchanging ToolHive-issued subject tokens. SPIFFE clients can also exchange tokens from a trusted external issuer, so the guide now covers both cases and links to the issuer policy setup. The embedded auth server pattern table is updated to match. Why: readers configuring an external issuer had no guidance on the policy fields they need. The guide also now warns that |
jhrozek
left a comment
There was a problem hiding this comment.
Approving. The docs changes match the SPIFFE and issuer policy behavior described in the guide.
This PR contains the following updates:
v0.64.0→v0.65.0After this PR opens,
.github/workflows/upstream-release-docs.ymladds source-verified content edits for the new release. Forstacklok/toolhive, the same workflow also syncs reference assets (CLI help, Swagger) and regenerates the CRD MDX pages.Release Notes
stacklok/toolhive
v0.65.0Compare Source
What's Changed
Full Changelog: stacklok/toolhive@v0.64.0...v0.65.0
Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Docs update for
toolhivev0.65.0Note
Silent run — skill produced no content commits. The docs are
likely already up-to-date (e.g.
mainahead of pin, or a re-runafter a previous PR for this tag merged). Only the version bump
and refreshed reference assets are included.
At a glance
stacklok/toolhivev0.64.0→v0.65.0Who does what
@aponcedeleonch cut this release and owns this PR: review your own changes, chase the remaining approvals, and merge once they're in. You don't need to wait on a review from anyone listed as having no docs impact below.
Everyone with a review request: the target is a review and approval within 2 business days.
Summary of changes
docs/toolhive/guides-vmcp/delegate-agent-identity.mdx, plus cross-links from the vMCP "Choose a way to get a token" table and the K8s embedded auth server field table and TLS listener sectionprivate_key_jwtassertion rules indocs/toolhive/guides-vmcp/delegate-agent-identity.mdxto cover the fixed 60-second clock-skew margin and the 6-minuteexpcapdocs/toolhive/guides-vmcp/accept-workload-assertions.mdx: removed the placeholderupstreamProvidersworkaround, since a JWT-bearer-only configuration is accepted without upstreamsdocs/toolhive/guides-k8s/embedded-auth-server-k8s.mdxanddocs/toolhive/guides-vmcp/embedded-auth-server-vmcp.mdxto describe serving an expired cached document when a re-fetch fails transientlymetadata.extra.trace_idandmetadata.extra.span_idto the audit field tables indocs/toolhive/guides-k8s/logging.mdxanddocs/toolhive/guides-vmcp/audit-logging.mdxid_jagtargets,id_jag_max_lifetime, actor-token validators): RunConfig or Go-embedder only, no CRD field, and nothing issues an ID-JAG at v0.65.0 (respondWithIDJAGhas no non-test caller)/openapi.yamlcap and the 4096-key YAML mapping limit (Bound registry openapi.yaml read and YAML decoding cost toolhive#7107, Avoid quadratic YAML decoding of untrusted skill files toolhive#7106): hardening limits that real registries and skill files don't reachacceptedAudiencesdefault for ID-JAG redemption (Add oauthproto/idjag with the XAA client and server rules toolhive#7103): the plain JWT-bearer default the docs describe is unchanged, and ID-JAG redemption by ToolHive isn't documented yet; the schema reference carries the new wordingGaps needing human context
SPIFFE client authentication: where workloads get a subject token (PR stacklok/toolhive#7092 by @jhrozek)
The new "Authenticate workloads with SPIFFE SVIDs" section documents the configuration and both SVID authentication paths, verified against source at v0.65.0. What it can't yet explain is the end-to-end workflow for the subject token. Source and tests show the subject token must be a ToolHive-issued access token whose
client_idis the SPIFFEclientIdor whosemay_act.subnames it, and the PR notes that "a SPIFFE-only server has no source for its first subject token unless another issuer shares its signing key." Neither the PR nor the architecture doc says how an operator is expected to get such a token to the workload in a real deployment (for example, alongside an upstream provider, or whether externaltrustedIssuerstokens are accepted for SPIFFE clients), so the section states only the acceptance rules.File(s): docs/toolhive/guides-vmcp/delegate-agent-identity.mdx
Helper prompt for local Claude:
Review routing
GitHub could not request the upstream contributor directly, so review went to the human merger of each relevant upstream PR:
Run cost
How this PR was built
Two Claude Opus sessions run per release: a generation pass
(
upstream-release-docsskill, 6 phases) followed by a fresh-context editorial pass (
docs-review). Prettier/ESLintauto-fixes are applied after.
Auto-synced paths — do not hand-edit these in review:
static/api-specs/docs/toolhive/reference/cli/(toolhive only)docs/toolhive/reference/crds/If a "Gaps needing human context" section is present above,
each entry includes a paste-ready Helper prompt for local
Claude a reviewer can use to resolve the gap.