Skip to content

Bump ske service dependency version and include serviceAccountIssuerin SKE cluster status#1505

Open
jastBytes wants to merge 15 commits into
stackitcloud:mainfrom
jastBytes:main
Open

Bump ske service dependency version and include serviceAccountIssuerin SKE cluster status#1505
jastBytes wants to merge 15 commits into
stackitcloud:mainfrom
jastBytes:main

Conversation

@jastBytes

@jastBytes jastBytes commented Jun 3, 2026

Copy link
Copy Markdown

Description

Update the dependency version for the ske service SDK within the go.mod file.

This bump includes several related updates across the ske service implementation, such as adding support for service_account_issuer fields and adjusting how certain types are assigned.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@jastBytes jastBytes requested a review from a team as a code owner June 3, 2026 11:07
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jun 13, 2026
@relusc

relusc commented Jun 16, 2026

Copy link
Copy Markdown

@GokceGK Can you estimate when you will have time to review the PR ? :)

@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label Jun 17, 2026
@Manuelvaas Manuelvaas changed the title Bump ske service dependency version and include serivceAccountIssuerin SKE cluster status Bump ske service dependency version and include serviceAccountIssuerin SKE cluster status Jun 17, 2026
jastBytes added 2 commits June 23, 2026 10:40
@jastBytes
Bump ske service dependency version
ffd10f4 
Update the dependency version for the ske service SDK within the go.mod
file.

This bump includes several related updates across the ske service
implementation, such as adding support for `service_account_issuer`
fields and adjusting how certain types are assigned.
@jastBytes
Add service account issuer to SKE cluster docs
61a286e
@jastBytes

jastBytes commented Jun 23, 2026

Copy link
Copy Markdown
Author

I have rebased my changes, could you have a look @Manuelvaas? Thank you!

@rubenhoenle

rubenhoenle commented Jun 23, 2026

Copy link
Copy Markdown
Member

Hi @jastBytes,
thanks for your contribution. Can you please also adjust the Acc tests to include checks for your new field?

https://github.com/stackitcloud/terraform-provider-stackit/blob/main/stackit/internal/services/ske/ske_acc_test.go

Best regards
Ruben from STACKIT Developer Tools team

jastBytes and others added 2 commits June 24, 2026 09:49
@jastBytes
Add service_account_issuer to test configurations
418daee 
- Added `service_account_issuer` to `testConfigVarsMin`,
  `testConfigVarsMax`, and test check resource attributes in
  `TestAccSKEMin` and `TestAccSKEMax`.
@jastBytes
Merge branch 'main' into main
395ebf0
rubenhoenle
rubenhoenle requested changes Jun 24, 2026
View reviewed changes

@rubenhoenle rubenhoenle left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Acc tests failing for reasons given in comments

Comment thread stackit/internal/services/ske/ske_acc_test.go Outdated
Comment thread stackit/internal/services/ske/ske_acc_test.go Outdated
Comment thread stackit/internal/services/ske/ske_acc_test.go Outdated
Comment thread stackit/internal/services/ske/ske_acc_test.go Outdated
Comment thread stackit/internal/services/ske/ske_acc_test.go Outdated
Comment thread stackit/internal/services/ske/ske_acc_test.go
@rubenhoenle rubenhoenle added the needs-work PR needs changes by the author. label Jun 24, 2026
@jastBytes

jastBytes commented Jun 26, 2026

Copy link
Copy Markdown
Author

I think I got the tests wrong since service_account_issuer is a read only field.

jastBytes and others added 3 commits June 26, 2026 13:39
@jastBytes
refactor(ske): removed service_account_issuer since it is read_only
2dcba27
@jastBytes
test(ske): use set attribute checks for service_account_issuer
aad5f23 
Update acceptance tests to verify that the service_account_issuer attribute is set
instead of asserting a specific value, reflecting its removal and read‑only status.
@jastBytes
Merge branch 'main' into main
6dc6d12
@jastBytes jastBytes requested a review from rubenhoenle June 29, 2026 09:35
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle approved these changes

Assignees

No one assigned

Labels

has internal tracking issue needs-work PR needs changes by the author. Stale PR is marked as stale due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jastBytes @relusc @rubenhoenle @GokceGK