feat(vpn): Onboarding VPN gateway by s-inter · Pull Request #1453 · stackitcloud/terraform-provider-stackit

s-inter · 2026-05-11T10:13:36Z

Description

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

…elines

rubenhoenle · 2026-05-18T08:46:24Z

+		gatewaysToDestroy = append(gatewaysToDestroy, gatewayId)
+	}
+
+	gatewaysResp, err := client.DefaultAPI.ListGateways(ctx, testutil.ProjectId, vpn.REGION_EU01).Execute()


Suggested change

gatewaysResp, err := client.DefaultAPI.ListGateways(ctx, testutil.ProjectId, vpn.REGION_EU01).Execute()

gatewaysResp, err := client.DefaultAPI.ListGateways(ctx, testutil.ProjectId, testutil.Region).Execute()

rubenhoenle · 2026-05-18T08:49:52Z

+					resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "display_name", testutil.ConvertConfigVariable(gatewayMaxVars["display_name"])),
+					resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "routing_type", testutil.ConvertConfigVariable(gatewayMaxVars["routing_type"])),
+					resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "bgp.local_asn", testutil.ConvertConfigVariable(gatewayMaxVars["local_asn"])),
+					resource.TestCheckResourceAttrSet("stackit_vpn_gateway.gateway", "gateway_id"),


What about availability_zones, region, labels, ...

You should check all fields here, even if it's a negative check that they are not set.

Applies everywhere

rubenhoenle · 2026-05-18T08:52:59Z

+					resource.TestCheckResourceAttrPair("data.stackit_vpn_gateway.gateway", "project_id", "stackit_vpn_gateway.gateway", "project_id"),
+					resource.TestCheckResourceAttrPair("data.stackit_vpn_gateway.gateway", "region", "stackit_vpn_gateway.gateway", "region"),
+					resource.TestCheckResourceAttrPair("data.stackit_vpn_gateway.gateway", "gateway_id", "stackit_vpn_gateway.gateway", "gateway_id"),
+					resource.TestCheckResourceAttrPair("data.stackit_vpn_gateway.gateway", "display_name", "stackit_vpn_gateway.gateway", "display_name"),


Duplicate check: Didn't you check the "display_name" field already above with the following line?

resource.TestCheckResourceAttr("data.stackit_vpn_gateway.gateway", "display_name", testutil.ConvertConfigVariable(gatewayMaxVars["display_name"])),

Applies to most of the fields here, don't duplicate checks. It blows the test up without any advantage IMO.

rubenhoenle · 2026-05-18T08:53:25Z

+				Config:          fmt.Sprintf("%s\n%s", testutil.NewConfigBuilder().BuildProviderConfig(), gatewayMaxConfig),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "display_name", testutil.ConvertConfigVariable(gatewayMaxVarsUpdated["display_name"])),
+					resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "bgp.local_asn", testutil.ConvertConfigVariable(gatewayMaxVarsUpdated["local_asn"])),


Check all fields here to detect potential drifts

rubenhoenle · 2026-05-18T08:53:55Z

+				Config:          fmt.Sprintf("%s\n%s", testutil.NewConfigBuilder().BuildProviderConfig(), gatewayMinConfig),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					// Gateway data
+					resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "project_id", testutil.ConvertConfigVariable(gatewayMinVars["project_id"])),


Co-authored-by: rubenhoenle <Ruben.Hoenle@digits.schwarz>

github-actions · 2026-05-18T11:05:17Z

Merging this branch changes the coverage (1 decrease, 2 increase)

Impacted Packages	Coverage Δ	🤖
github.com/stackitcloud/terraform-provider-stackit/stackit	1.23% (-0.02%)	👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core	21.62% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn	0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/gateway	18.97% (+18.97%)	🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/utils	77.78% (+77.78%)	🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil	39.83% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core/core.go	21.62% (ø)	37	8	29
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/gateway/datasource.go	0.00% (ø)	42 (+42)	0	42 (+42)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/gateway/resource.go	22.18% (+22.18%)	248 (+248)	55 (+55)	193 (+193)	🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/utils/utils.go	77.78% (+77.78%)	9 (+9)	7 (+7)	2 (+2)	🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil/testutil.go	51.09% (ø)	92	47	45
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go	1.23% (-0.02%)	163 (+2)	2	161 (+2)	👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/gateway/datasource_test.go
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/gateway/resource_test.go
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/utils/utils_test.go
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/vpn/vpn_acc_test.go

s-inter added 7 commits May 11, 2026 12:05

feat(vpn): add vpn to provider and core

38faf3b

feat(vpn): add utils

c7bc13a

feat(vpn): add datasource for VPN gateway

84a4998

feat(vpn): add resource for VPN gateway

7dbf049

feat(vpn): add unit tests for VPN gateway

ce6c205

feat(vpn): add test data and acceptance tests for VPN gateway

907878a

fix(vpn): resolve linter issues - linter bypass per contribution guid…

161ec48

…elines

s-inter changed the title ~~Si/onboard vpn gateway~~ feat(vpn): Onboarding VPN gateway May 11, 2026

fix(vpn): update gateway tests to use new() function

d7c6581

rubenhoenle reviewed May 11, 2026

View reviewed changes

Comment thread stackit/internal/services/vpn/vpn_acc_test.go

rubenhoenle reviewed May 11, 2026

View reviewed changes

Comment thread stackit/internal/services/vpn/vpn_acc_test.go

rubenhoenle reviewed May 11, 2026

View reviewed changes

Comment thread stackit/internal/services/vpn/gateway/datasource.go Outdated

s-inter and others added 6 commits May 11, 2026 14:50

feat(vpn): add example resource for VPN gateway

f9bce3e

fix(vpn): update VPN gateway data source schema and add acceptance tests

046bce8

feat(vpn): upgrade to v1 api version

b3b1b93

Merge branch 'main' into si/onboard-VPN-gateway

1f5dc72

feat(vpn): update vpn service dependency to v0.8.0

9dddb67

feat(docs): add VPN Gateway documentation

a1d144a

s-inter marked this pull request as ready for review May 13, 2026 12:14

s-inter requested a review from a team as a code owner May 13, 2026 12:14

Merge branch 'main' into si/onboard-VPN-gateway

3f3255a

rubenhoenle reviewed May 18, 2026

View reviewed changes

fix(vpn): apply review suggestions

89f8aa4

Co-authored-by: rubenhoenle <Ruben.Hoenle@digits.schwarz>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vpn): Onboarding VPN gateway#1453

feat(vpn): Onboarding VPN gateway#1453
s-inter wants to merge 16 commits into
mainfrom
si/onboard-VPN-gateway

s-inter commented May 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rubenhoenle May 18, 2026

Uh oh!

rubenhoenle May 18, 2026

Uh oh!

rubenhoenle May 18, 2026

Uh oh!

rubenhoenle May 18, 2026

Uh oh!

rubenhoenle May 18, 2026

Uh oh!

rubenhoenle May 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	gatewaysResp, err := client.DefaultAPI.ListGateways(ctx, testutil.ProjectId, vpn.REGION_EU01).Execute()
	gatewaysResp, err := client.DefaultAPI.ListGateways(ctx, testutil.ProjectId, testutil.Region).Execute()

Conversation

s-inter commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rubenhoenle May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rubenhoenle May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rubenhoenle May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rubenhoenle May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rubenhoenle May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rubenhoenle May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Merging this branch changes the coverage (1 decrease, 2 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

s-inter commented May 11, 2026 •

edited

Loading