feat(sfs): add labels to sfs resources#1430
Open
Manuelvaas wants to merge 1 commit into
Open
Conversation
Manuelvaas
force-pushed
the
feature/add-labels-to-sfs-resources
branch
from
942fc7e to
6b8c3f8
Compare
Manuelvaas
changed the title
marceljk
reviewed
Apr 28, 2026
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Manuelvaas
force-pushed
the
feature/add-labels-to-sfs-resources
branch
from
8da2fbf to
c405e64
Compare
relates to STACKITTPR-525
Manuelvaas
force-pushed
the
feature/add-labels-to-sfs-resources
branch
from
c405e64 to
fd88279
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
GokceGK
reviewed
May 18, 2026
| Computed: true, | ||
| }, | ||
| "labels": schema.MapAttribute{ | ||
| Description: "Labels are key-value string pairs which can be attached to a resource pool", |
Contributor
There was a problem hiding this comment.
Suggested change
| Description: "Labels are key-value string pairs which can be attached to a resource pool", | |
| Description: "Labels are key-value string pairs which can be attached to an export policy", |
GokceGK
reviewed
May 18, 2026
| true, | ||
| }, | ||
| { | ||
| "Key to long", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Key to long", | |
| "Key too long", |
GokceGK
reviewed
May 18, 2026
| false, | ||
| }, | ||
| { | ||
| "Key to short", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Key to short", | |
| "Key too short", |
GokceGK
reviewed
May 18, 2026
| true, | ||
| }, | ||
| { | ||
| "Value to long", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Value to long", | |
| "Value too long", |
GokceGK
reviewed
May 18, 2026
| isValid: true, | ||
| }, | ||
| { | ||
| name: "Valid Labels", |
Contributor
There was a problem hiding this comment.
Can you align these also with expectedOutput row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-525
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)