feat(telemetryrouter): Onboarding TelemetryRouter#1425
Open
ozanichkovsky wants to merge 11 commits into
Open
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
added 2 commits
May 5, 2026 15:08
…ackit into feature/telemetryrouter
ozanichkovsky
changed the title
GokceGK
reviewed
May 12, 2026
GokceGK
reviewed
May 12, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
8 tasks
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
GokceGK
reviewed
May 13, 2026
| "config_filter_matcher": config.StringVariable("="), | ||
| "config_filter_value0": config.StringVariable("value1"), | ||
| "config_filter_value1": config.StringVariable("value2"), | ||
| "config_opentelemetry_bearer_token": config.StringVariable("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"), |
Contributor
There was a problem hiding this comment.
You should not use hard coded token like that. This wont work.
Author
There was a problem hiding this comment.
Destination represents an external destination logs are sent to. So it is a value, which a service user provides, not something that is generated by us.
Author
There was a problem hiding this comment.
The only possibility I probably see is to use another instance as a destination with a token created for that instance. Should it be done that way?
Contributor
There was a problem hiding this comment.
What is meant by the external destination ? Where is this token generated and provided? Do we have another resource dependency? What is the lifetime of this token?
In worst case scenario, the token must be given via ENV variable. Cause we want to run our acc tests without changing the code base with new values.
Co-authored-by: Gökce Gök Klingel <161626272+GokceGK@users.noreply.github.com>
Co-authored-by: Gökce Gök Klingel <161626272+GokceGK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Telemetry Router resources and datasource
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)