Feat/add custom role resource and data source #1077
Conversation
Markus-Schwer
force-pushed
the
feat/add-custom-role-resource-and-data-source
branch
from
c2d2f27 to
6d5a812
Compare
Markus-Schwer
force-pushed
the
feat/add-custom-role-resource-and-data-source
branch
from
6d5a812 to
41d31e7
Compare
|
I will add the examples on monday |
| go 1.24.0 | ||
|
|
||
| require ( | ||
| dev.azure.com/schwarzit/schwarzit.stackit-public/stackit-sdk-go-internal.git/services/authorization v0.0.0-20251126130857-9f2211a4c524 |
There was a problem hiding this comment.
internal SDK modules shouldn't be used
There was a problem hiding this comment.
Ah, I forgot to remove it after testing...
| } | ||
|
|
||
| // TypeConverter Helper to convert objects with equal JSON tags. | ||
| func TypeConverter[R any](data any) (*R, error) { |
There was a problem hiding this comment.
Could we have some tests for this?
There was a problem hiding this comment.
We might want to review this before: #1058
I've refactored the authorization code and also added tests for the type converter.
|
To clarify: this PR cannot be merged right now, because the API it uses is not public yet. We will make it public soon. When it is public, I will use the newly generated SDK and test this change again. Then it can be merged. For now I would still appreciate it if you review the changes, so that we can quickly merge this PR once the API is released. |
4 participants
Description
relates to STACKITIAM-1100
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)