feat: extend adelete_document method to include remove_from_storage o…#225
Merged
feat: extend adelete_document method to include remove_from_storage o…#225
Conversation
- Added abstract class `FileService` for handling file I/O operations. - Created concrete implementation `S3Service` for interacting with S3 storage. - Introduced `S3Settings` class for managing S3 configuration. - Updated `poetry.lock` files for dependencies related to AWS SDK (boto3, botocore, jmespath, s3transfer). - Added file service interfaces in `rag_core_lib`.
…oject.toml and poetry.lock
robodev-r2d2
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the
admin-api-libandextractor-api-liblibraries, focusing on better modularization through re-exports, enhanced document deletion logic, and improved development and testing workflows. The most significant changes are grouped below.1. Codebase Modularization and Re-exports
FileService,S3Service, andS3Settingsclasses inadmin-api-libandextractor-api-libnow re-export their implementations fromrag-core-lib, removing local duplicate definitions and ensuring consistency across libraries. [1] [2] [3]2. Document Deletion API Enhancements
DocumentDeleterinterface and its default implementation now accept a newremove_from_storageargument, allowing callers to control whether the file is deleted from storage in addition to the key-value store. The logic for file deletion was refactored to handle storage keys more robustly and to provide clearer error handling and logging. [1] [2] [3] [4] [5] [6]3. Upstream Usage and Test Updates
adelete_documentin file and source uploaders, as well as related tests, have been updated to use the newremove_from_storageparameter, ensuring correct behavior and test coverage for the enhanced deletion API. [1] [2] [3] [4]4. Docker and Build System Improvements
libs/Dockerfilehave been updated to include and installrag-core-libas a dependency where needed, improving development workflows and ensuring all necessary dependencies are available for testing and running the services. [1] [2] [3]These changes collectively improve code maintainability, modularity, and the flexibility of document management operations across the codebase.
** issue:
#224