[GEP-33] Add Capability support - #206
Open
aniruddha2000 wants to merge 11 commits into
Open
Conversation
|
Skipping CI for Draft Pull Request. |
ske-prow
Bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
size/M
aniruddha2000
force-pushed
the
add-capability
branch
from
July 13, 2026 09:17
57d62ad to
3646083
Compare
ske-prow
Bot
added
size/XL
ske-prow
Bot
added
size/XXL
aniruddha2000
marked this pull request as ready for review
July 23, 2026 07:14
ske-prow
Bot
added
needs-rebase
ske-prow
Bot
removed
the
needs-rebase
Contributor
|
/hold risk of regression. needs heavy-testing |
ske-prow
Bot
added
the
do-not-merge/hold
nschad
reviewed
Aug 3, 2026
timebertt
reviewed
Aug 4, 2026
timebertt
left a comment
timebertt
left a comment
Member
There was a problem hiding this comment.
In general, this PR is very hard to review.
We had a look together with @breuerfelix @viragvoros @nschad, but haven't made it through all of it. We had a look at the API types, helpers and some parts of the validation.
| return allErrs | ||
| } | ||
|
|
||
| func validateMachineImageCapabilities(machineImage core.MachineImage, version gardencorev1beta1.MachineImageVersion, providerImageVersion stackitv1alpha1.MachineImageVersion, capabilityDefinitions []gardencorev1beta1.CapabilityDefinition) field.ErrorList { |
Member
There was a problem hiding this comment.
Why is the entire validation for NamespacedCloudProfiles implemented in this package, while validation for CloudProfiles is implemented in the dedicated validation package?
Can we consolidate this? (Could also be in a separate PR)
Contributor
There was a problem hiding this comment.
will be done in a seperate PR
nschad
force-pushed
the
add-capability
branch
3 times, most recently
from
August 4, 2026 10:54
6065917 to
b46da81
Compare
ske-prow
Bot
added
the
needs-rebase
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
nschad
force-pushed
the
add-capability
branch
2 times, most recently
from
August 12, 2026 13:02
34917b9 to
fcca803
Compare
ske-prow
Bot
removed
the
needs-rebase
breuerfelix
reviewed
Aug 20, 2026
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
…ype as default" and move to seperate PR Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind api-change
/kind enhancement
What this PR does / why we need it:
This PR is part of GEP-33 Machine Image Capabilities
It adopts the introduced Cloud Profile Capabilities from Gardener. It offers a mechanism to define a relationships between MachineTypes and MachineImages to ensure only compatible amis are selected for a given MachineType. An example for a Capability is the CPU architecture that is added as the first mandatory Capability. The existing architecture field is planned to be removed eventually.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: