Skip to content

Add addmission webhook for shoot object#203

Open
dergeberl wants to merge 2 commits into
mainfrom
addAddmissionWebhook
Open

Add addmission webhook for shoot object#203
dergeberl wants to merge 2 commits into
mainfrom
addAddmissionWebhook

Conversation

@dergeberl

@dergeberl dergeberl commented Jul 8, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement
/cc @stackitcloud/ske-infrastructure

What this PR does / why we need it:

We already have validation functions for the ControlPlaneConfig and InfrastructureConfig but we had no validation webhook for the shoot object. This PR adds the webhook.

It also fixes the InfrastructureConfig as this was not working, as it is possible to habe no InfrastructureConfig.Networks.Workers if InfrastructureConfig.Networks.ID is set.

I created a cluster with and without SNA via the ske-api.

We want to use this for the ALB integration #54

Special notes for your reviewer:

Please also check the validation itself as this was not used before and needed already adoption in the InfrastructureConfig part.

@ske-prow ske-prow Bot requested a review from a team July 8, 2026 14:40
@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jul 8, 2026
@ske-prow

ske-prow Bot commented Jul 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dergeberl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2026
@dergeberl dergeberl force-pushed the addAddmissionWebhook branch from 04177a8 to 9b8a7b5 Compare July 8, 2026 14:52
@ske-prow

ske-prow Bot commented Jul 8, 2026

Copy link
Copy Markdown

@dergeberl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-provider-stackit-integration-tests 9b8a7b5 link true /test pull-gardener-extension-provider-stackit-integration-tests

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant