Add addmission webhook for shoot object#203
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
04177a8 to
9b8a7b5
Compare
|
@dergeberl: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
How to categorize this PR?
/kind enhancement
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
We already have validation functions for the
ControlPlaneConfigandInfrastructureConfigbut we had no validation webhook for the shoot object. This PR adds the webhook.It also fixes the
InfrastructureConfigas this was not working, as it is possible to habe noInfrastructureConfig.Networks.WorkersifInfrastructureConfig.Networks.IDis set.I created a cluster with and without SNA via the ske-api.
We want to use this for the ALB integration #54
Special notes for your reviewer:
Please also check the validation itself as this was not used before and needed already adoption in the
InfrastructureConfigpart.