node-controller: support multi-nic#1307
Conversation
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
hammadzf
left a comment
There was a problem hiding this comment.
Review done together with @crigertg and @aniruddha2000
Minor suggestions and clarifying questions here and there, otherwise the approach looks good to us.
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
Co-authored-by: Niclas Schad <niclas.schad@stackit.cloud>
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
|
@hown3d: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@hammadzf: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
needs a quick |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Nodes with multiple NICs attached report in a non-deterministic way which IP to use as the primary one since the NICs of a server are returned in non-deterministic order from the Iaas API.
This PR ensures to always sort the returned NICs as well as having the option to specify a defaultNetwork, which when set, reports the NIC of the network on index 0.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: