Skip to content

node-controller: support multi-nic#1307

Open
hown3d wants to merge 6 commits into
mainfrom
sort-node-addresses
Open

node-controller: support multi-nic#1307
hown3d wants to merge 6 commits into
mainfrom
sort-node-addresses

Conversation

@hown3d

@hown3d hown3d commented Jul 6, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
Nodes with multiple NICs attached report in a non-deterministic way which IP to use as the primary one since the NICs of a server are returned in non-deterministic order from the Iaas API.

This PR ensures to always sort the returned NICs as well as having the option to specify a defaultNetwork, which when set, reports the NIC of the network on index 0.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

hown3d added 2 commits July 1, 2026 15:03
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jul 6, 2026
@ske-prow

ske-prow Bot commented Jul 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign robinschneider for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2026

@hammadzf hammadzf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done together with @crigertg and @aniruddha2000

Minor suggestions and clarifying questions here and there, otherwise the approach looks good to us.

Comment thread docs/cloud-controller-manager.md
Comment thread docs/cloud-controller-manager.md Outdated
Comment thread pkg/ccm/instances.go
Comment thread pkg/ccm/instances_test.go
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
Comment thread pkg/ccm/instances.go
Comment thread pkg/ccm/instances_test.go Outdated
hown3d and others added 3 commits July 7, 2026 15:56
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
Co-authored-by: Niclas Schad <niclas.schad@stackit.cloud>
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
@ske-prow

ske-prow Bot commented Jul 7, 2026

Copy link
Copy Markdown

@hown3d: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-stackit-verify be44443 link true /test pull-cloud-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hammadzf

hammadzf commented Jul 7, 2026

Copy link
Copy Markdown

/lgtm

@ske-prow

ske-prow Bot commented Jul 7, 2026

Copy link
Copy Markdown

@hammadzf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nschad

nschad commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

needs a quick make fmt. sorry @hown3d my comment has some extra spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants