Skip to content

Install correct version of networking-mlnx for openstack release - #2549

Open
jovial wants to merge 2 commits into
stackhpc/2025.1from
bugfix/2025.1/networking-mlnx
Open

Install correct version of networking-mlnx for openstack release#2549
jovial wants to merge 2 commits into
stackhpc/2025.1from
bugfix/2025.1/networking-mlnx

Conversation

@jovial

@jovial jovial commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Updated neutron_mlnx_agent_pip_packages_override to use the stackhpc branch based on openstack_release.

(cherry picked from commit 468d407)

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2e8d2579-4989-413e-bc98-2e49eb595d86

📥 Commits

Reviewing files that changed from the base of the PR and between a5b8b04 and 807c094.

📒 Files selected for processing (2)
  • etc/kayobe/kolla-image-tags.yml
  • etc/kayobe/kolla.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Ansible 2.18 lint with Python 3.12
  • GitHub Check: Ansible 2.17 lint with Python 3.10
🔇 Additional comments (2)
etc/kayobe/kolla-image-tags.yml (1)

14-17: LGTM!

etc/kayobe/kolla.yml (1)

519-519: LGTM!


📝 Walkthrough
  • Pin the Neutron image tag for supported distributions.
  • Select the StackHPC networking-mlnx branch that matches openstack_release.
  • Ensure images install the correct networking-mlnx version for each OpenStack release.

Walkthrough

The change adds pinned Neutron image tags for three distributions and updates the MLNX agent package source to the StackHPC release branch.

Changes

Neutron configuration

Layer / File(s) Summary
Pin Neutron image tags
etc/kayobe/kolla-image-tags.yml
Adds Neutron image tags for Rocky 9, Rocky 10, and Ubuntu Noble.
Update MLNX package source
etc/kayobe/kolla.yml
Changes networking-mlnx to use the StackHPC repository and stackhpc/{{ openstack_release }} reference.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 807c0

This localized dependency-version configuration change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Aug 25, 2026
Updated neutron_mlnx_agent_pip_packages_override to use the stackhpc
branch based on openstack_release.

(cherry picked from commit 468d407)
@jovial
jovial force-pushed the bugfix/2025.1/networking-mlnx branch from dabc113 to ad56b8b Compare August 25, 2026 11:06
@jovial

jovial commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@jovial
jovial marked this pull request as ready for review August 25, 2026 16:02
@jovial
jovial requested a review from a team as a code owner August 25, 2026 16:02
@jovial

jovial commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

This is tested and working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant