Install correct version of networking-mlnx for openstack release - #2548
Install correct version of networking-mlnx for openstack release#2548jovial wants to merge 1 commit into
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughUpdate WalkthroughThe Kolla build configuration now installs ChangesMLNX package source selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to The change can select a nonexistent networking-mlnx branch for the default OpenStack release, which may stop the MLNX image build. Update the release-to-branch mapping before merging. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 56e17421-f7cd-422d-aa05-6a4d6228e5ca
📒 Files selected for processing (1)
etc/kayobe/kolla.yml
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: stackhpc/check-review
- GitHub Check: Build Kayobe Image / Build kayobe image
- GitHub Check: stackhpc/check
| - python3-libvirt | ||
| neutron_mlnx_agent_pip_packages_override: | ||
| - networking-mlnx@git+https://opendev.org/x/networking-mlnx@master | ||
| - networking-mlnx@git+https://opendev.org/x/networking-mlnx@stackhpc/{{ openstack_release }} |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
#!/bin/bash
set -euo pipefail
repo='https://opendev.org/x/networking-mlnx'
mapfile -t releases < <(
rg -No '^[[:space:]]*openstack_release[[:space:]]*:[[:space:]]*[^[:space:]#]+' \
--glob '*.yml' --glob '*.yaml' . |
sed -E 's/^[^:]+:[0-9]+:[[:space:]]*//; s/^["'\'']|["'\'']$//g' |
grep -v '{{' |
sort -u
)
if [ "${`#releases`[@]}" -eq 0 ]; then
echo 'No literal openstack_release values found; verify the supported release list manually.' >&2
exit 2
fi
failed=0
for release in "${releases[@]}"; do
if ! git ls-remote --exit-code --heads \
"$repo" "refs/heads/stackhpc/$release" >/dev/null; then
echo "Missing branch: stackhpc/$release" >&2
failed=1
fi
done
exit "$failed"Repository: stackhpc/stackhpc-kayobe-config
Length of output: 221
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- changed lines ---'
sed -n '224,240p' etc/kayobe/kolla.yml
printf '%s\n' '--- openstack_release declarations ---'
rg -n --glob '*.yml' --glob '*.yaml' \
'^[[:space:]]*openstack_release[[:space:]]*:' .
printf '%s\n' '--- networking-mlnx references ---'
rg -n --glob '*.yml' --glob '*.yaml' \
'networking-mlnx|stackhpc/' .
printf '%s\n' '--- remote branches ---'
git ls-remote --heads https://opendev.org/x/networking-mlnx \
'refs/heads/stackhpc/*' | sortRepository: stackhpc/stackhpc-kayobe-config
Length of output: 9387
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- all openstack_release references ---'
rg -n --hidden --glob '!/.git/**' 'openstack_release' .
printf '%s\n' '--- all networking-mlnx remote heads ---'
git ls-remote --heads https://opendev.org/x/networking-mlnx | rg 'refs/heads/(stackhpc/|stable/|master$)' || true
printf '%s\n' '--- remote HEAD and matching release refs ---'
git ls-remote https://opendev.org/x/networking-mlnx \
HEAD \
'refs/heads/stackhpc/*' \
'refs/tags/stackhpc/*' || trueRepository: stackhpc/stackhpc-kayobe-config
Length of output: 12900
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- release selection and supported releases ---'
sed -n '1,110p' .github/workflows/multinode-inputs.py
sed -n '25,48p' .github/workflows/stackhpc-container-image-build.yml
sed -n '78,92p' .github/workflows/overcloud-host-image-build.yml
sed -n '1,18p' etc/kayobe/openstack.yml
printf '%s\n' '--- exact branch checks for releases used by CI ---'
for release in 2025.1 2025.2 2026.1; do
printf 'stackhpc/%s: ' "$release"
git ls-remote --exit-code --heads \
https://opendev.org/x/networking-mlnx \
"refs/heads/stackhpc/$release" || true
printf 'stable/%s: ' "$release"
git ls-remote --exit-code --heads \
https://opendev.org/x/networking-mlnx \
"refs/heads/stable/$release" || true
doneRepository: stackhpc/stackhpc-kayobe-config
Length of output: 5801
Use a branch that exists in opendev.org/x/networking-mlnx.
The current default openstack_release is 2026.1, but stackhpc/2026.1 does not exist. The repository provides stable/2026.1 instead. Pip can therefore fail to resolve this requirement and stop the MLNX image build. Use an explicit mapping for each supported release.
There was a problem hiding this comment.
@Alex-Welsh, thank you. 🐇
You are interacting with an AI system.
Updated neutron_mlnx_agent_pip_packages_override to use the stackhpc branch based on openstack_release.
468d407 to
84b017a
Compare
|
We likely need to restore the installation of networking-mlnx into neutron and nova containers since I believe they are not installed by default. |
3 participants
Updated neutron_mlnx_agent_pip_packages_override to use the stackhpc branch based on openstack_release.