Fix Redfish exporter scrape configuration

[priteau]

When hosts are enrolled with Redfish, the generated inventory uses redfish_address instead of ipmi_address, resulting in wrong Prometheus scrape configuration for the Redfish exporter.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6f2c6762-a9aa-42cd-b2a6-9b51a32c0713

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Updated Redfish exporter configuration to use redfish_address when available, with ipmi_address as a fallback. Updated monitoring documentation and added a release note.

Walkthrough

The Redfish exporter target address now uses redfish_address when available and falls back to ipmi_address. The monitoring documentation matches this behaviour, and a release note records the fix.

Changes

Redfish exporter address selection

Layer / File(s)	Summary
Configure Redfish exporter address fallback etc/kayobe/stackhpc-monitoring.yml, doc/source/configuration/monitoring.rst, releasenotes/notes/use-redfish-address-for-redfish-exporter-ae1504867ef77d59.yaml	The monitoring setting and its documented default use {{ redfish_address or ipmi_address }}. The release note documents the correction.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: 🟡 Moderate · up to b683f

The scrape configuration can fail for baremetal-IPMI hosts because the optional Redfish address is evaluated before the IPMI fallback. Update the configuration and documentation to use an undefined-safe fallback before merging.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4cf1b4b2-6251-437f-8773-58265c86b09b

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa8c88 and b683fa2.

📒 Files selected for processing (3)

• doc/source/configuration/monitoring.rst
• etc/kayobe/stackhpc-monitoring.yml
• releasenotes/notes/use-redfish-address-for-redfish-exporter-ae1504867ef77d59.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details

⏰ Context from checks skipped due to timeout. (3)

• GitHub Check: stackhpc/check
• GitHub Check: Ansible 2.20 lint with Python 3.12
• GitHub Check: Ansible 2.19 lint with Python 3.12

🔇 Additional comments (1)

releasenotes/notes/use-redfish-address-for-redfish-exporter-ae1504867ef77d59.yaml (1)

1-5: LGTM!