Make StorageFillingUp alert customisable

[jovial]

Add alertmanager_storage_filling_up_excluded_mountpoints and alertmanager_storage_filling_up_excluded_hosts variables to allow excluding specific mountpoints and hosts from the StorageFillingUp Prometheus alert.

[coderabbitai]

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9d5a9418-cf94-4495-b2e7-30b8aa60abb4

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa8c88 and e12d08f.

📒 Files selected for processing (3)

• etc/kayobe/kolla/config/prometheus/ceph.rules
• etc/kayobe/stackhpc-monitoring.yml
• releasenotes/notes/customise-storage-filling-up-alert-9f6b1c2e1a4d8b3f.yaml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 74450f25-cf27-4bea-9bac-e0391793950a

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa8c88 and e12d08f.

📒 Files selected for processing (3)

• etc/kayobe/kolla/config/prometheus/ceph.rules
• etc/kayobe/stackhpc-monitoring.yml
• releasenotes/notes/customise-storage-filling-up-alert-9f6b1c2e1a4d8b3f.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (2)

• GitHub Check: Build Kayobe Image / Build kayobe image
• GitHub Check: stackhpc/check

🔇 Additional comments (3)

etc/kayobe/stackhpc-monitoring.yml (1)

29-37: LGTM!

releasenotes/notes/customise-storage-filling-up-alert-9f6b1c2e1a4d8b3f.yaml (1)

1-10: LGTM!

etc/kayobe/kolla/config/prometheus/ceph.rules (1)

163-164: LGTM!

---

📝 Walkthrough

Adds two variables to exclude selected mountpoints and hosts from the StorageFillingUp Prometheus alert. Both variables accept regular expressions and default to empty strings. Updates the configuration and release notes.

Walkthrough

The StorageFillingUp Prometheus alert now supports regular-expression exclusions for filesystem mountpoints and hosts. Both settings default to empty strings, and the release note documents their use.

Changes

Storage alert exclusions

Layer / File(s)	Summary
Exclusion configuration etc/kayobe/stackhpc-monitoring.yml, releasenotes/notes/...	Adds empty-by-default regular-expression settings for excluded mountpoints and hosts. Documents the new settings.
Alert rule filtering etc/kayobe/kolla/config/prometheus/ceph.rules	Filters configured mountpoints and hostnames before applying the five-day predict_linear capacity check.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e12d0

This localized change adds configuration options for excluding selected hosts and mountpoints from the storage-capacity alert; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Alex-Welsh]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[Alex-Welsh]

@coderabbitai full review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 54 minutes.