Skip to content

Improve rocky-97-ofed-upgrade.yml playbook#2166

Merged
priteau merged 2 commits intostackhpc/2025.1from
rocky-97-ofed-upgrade-fix
Feb 20, 2026
Merged

Improve rocky-97-ofed-upgrade.yml playbook#2166
priteau merged 2 commits intostackhpc/2025.1from
rocky-97-ofed-upgrade-fix

Conversation

@priteau
Copy link
Member

@priteau priteau commented Feb 19, 2026

No description provided.

@priteau priteau requested a review from elelaysh February 19, 2026 18:16
@priteau priteau self-assigned this Feb 19, 2026
@priteau priteau requested a review from a team as a code owner February 19, 2026 18:16
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the name of an Ansible task in etc/kayobe/ansible/maintenance/rocky-97-ofed-upgrade.yml to be more descriptive. The new name, Update all packages (this can take a long time), clarifies the action and helpfully warns the operator about the potential for a long execution time. This is a good change that improves the playbook's usability. I have no further feedback.

This can be useful if the playbook has been interrupted before
finishing, but the rocky-release package is already updated to 9.7.
@priteau priteau changed the title Clarify name of package update task Improve rocky-97-ofed-upgrade.yml playbook Feb 19, 2026
@priteau
Copy link
Member Author

priteau commented Feb 19, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a bypass mechanism for the Rocky Linux 9.6 version check and clarifies the name of the package update task. The changes improve the flexibility of the playbook by allowing administrators to skip the version check when necessary, and enhance readability by providing a more descriptive task name. The changes are straightforward and address potential operational needs.

Copy link
Contributor

@elelaysh elelaysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteau priteau enabled auto-merge February 20, 2026 08:42
@priteau priteau disabled auto-merge February 20, 2026 15:20
@priteau priteau merged commit cb8b718 into stackhpc/2025.1 Feb 20, 2026
21 of 22 checks passed
@priteau priteau deleted the rocky-97-ofed-upgrade-fix branch February 20, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments