Fix Amphora register playbook failing when using TLS#2162
Draft
seunghun1ee wants to merge 1 commit intostackhpc/2025.1from
Draft
Fix Amphora register playbook failing when using TLS#2162seunghun1ee wants to merge 1 commit intostackhpc/2025.1from
seunghun1ee wants to merge 1 commit intostackhpc/2025.1from
Conversation
Member
Author
|
It would be nice to backport this to Caracal too. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the TLS issue by introducing the openstack_cacert variable and applying it to the OpenStack modules. It also transitions the image renaming task to use the openstack.cloud.image module. However, the implementation of the rename task contains a logic error: by including the filename parameter, the module will attempt to upload the new image data to the old image ID because their checksums differ. This results in an unnecessary and incorrect data upload during what should be a simple rename operation. I have provided a suggestion to simplify this task.
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
CA certificate was not injected correctly for this playbook. Plus, using openstack.cloud.image Ansible module for renaming the existing old Amphora image.
seunghun1ee
force-pushed
the
fix-amphora-register
branch
from
c115157 to
9597d2a
Compare
Member
Author
|
Need more tests. Switch to draft. |
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CA certificate was not injected correctly for this playbook.
Plus, using openstack.cloud.image Ansible module for renaming the existing old Amphora image.