-
Notifications
You must be signed in to change notification settings - Fork 23
Update prometheus rules for job rename #2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
redfish-exporter-seed was renamed redfish-exporter in: 782f689 This updates the rules to match. Effectively making failed redfish scrapes warnings again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Prometheus alert rules to reflect the renaming of the redfish-exporter-seed job to redfish-exporter. The changes correctly update the job name in the alert expressions. I have added one comment with a suggestion to fully align the alert rule with the intent described in the pull request (changing the severity to 'warning') and to improve its actionability by adding annotations.
| - alert: PrometheusTargetMissing | ||
| expr: up{job="redfish-exporter-seed"} == 0 | ||
| expr: up{job="redfish-exporter"} == 0 | ||
| for: 15m | ||
| labels: | ||
| severity: critical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This alert rule could be improved in a couple of ways:
- Severity: The pull request description states that the intention is to make failed redfish scrapes warnings again. To align with this, the severity should be changed from
criticaltowarning. - Annotations: This alert is missing an
annotationssection, which is crucial for providing context when an alert fires. Addingsummaryanddescriptionannotations would make the alert more informative.
Here is a suggestion that incorporates these improvements:
- alert: PrometheusTargetMissing
expr: up{job="redfish-exporter"} == 0
for: 15m
labels:
severity: warning
annotations:
summary: "Prometheus redfish-exporter target missing (instance {{ $labels.instance }})"
description: "The redfish-exporter target has disappeared. The exporter might have crashed."
redfish-exporter-seed was renamed redfish-exporter in:
782f689
This updates the rules to match. Effectively making failed redfish scrapes warnings again.