Skip to content

Conversation

@jovial
Copy link
Contributor

@jovial jovial commented Nov 28, 2025

redfish-exporter-seed was renamed redfish-exporter in:

782f689

This updates the rules to match. Effectively making failed redfish scrapes warnings again.

redfish-exporter-seed was renamed redfish-exporter in:

782f689

This updates the rules to match. Effectively making failed redfish scrapes warnings again.
@jovial jovial requested a review from a team as a code owner November 28, 2025 18:11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Prometheus alert rules to reflect the renaming of the redfish-exporter-seed job to redfish-exporter. The changes correctly update the job name in the alert expressions. I have added one comment with a suggestion to fully align the alert rule with the intent described in the pull request (changing the severity to 'warning') and to improve its actionability by adding annotations.

Comment on lines 18 to 22
- alert: PrometheusTargetMissing
expr: up{job="redfish-exporter-seed"} == 0
expr: up{job="redfish-exporter"} == 0
for: 15m
labels:
severity: critical
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This alert rule could be improved in a couple of ways:

  1. Severity: The pull request description states that the intention is to make failed redfish scrapes warnings again. To align with this, the severity should be changed from critical to warning.
  2. Annotations: This alert is missing an annotations section, which is crucial for providing context when an alert fires. Adding summary and description annotations would make the alert more informative.

Here is a suggestion that incorporates these improvements:

  - alert: PrometheusTargetMissing
    expr: up{job="redfish-exporter"} == 0
    for: 15m
    labels:
      severity: warning
    annotations:
      summary: "Prometheus redfish-exporter target missing (instance {{ $labels.instance }})"
      description: "The redfish-exporter target has disappeared. The exporter might have crashed."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants