Switch to official geerlingguy.docker role #2010
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The role was recently updated to use ansible_facts [1]. [1] geerlingguy/ansible-role-docker@c0ddaa9
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request switches from a forked ansible-role-docker to the official geerlingguy.docker role, version 7.8.0. This is a good change that improves maintainability by using the upstream version. The change is correct, but it makes a related comment obsolete, which I've pointed out in a review comment.
mnasiadka
reviewed
Nov 28, 2025
Member
mnasiadka
left a comment
mnasiadka
left a comment
There was a problem hiding this comment.
Is there a reason why we use this, not ansible-collection-kolla docker role?
Member
Author
It appears to be used only for the |
Contributor
|
I think we can merge this however I would like to move to ansible-collection-kolla docker to help reduce dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role was recently updated to use ansible_facts [1].
[1] geerlingguy/ansible-role-docker@c0ddaa9