feat(versioned): Emit generics in plain From impl - #1284
Merged
Techassi merged 2 commits intoSep 29, 2026
Merged
Conversation
NickLarsenNZ
previously approved these changes
Sep 29, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
LGTM
Some snapshot tests would be nice, but feel free to do that in a follow up.
Techassi
enabled auto-merge
September 29, 2026 07:24
Member
|
feat or fix? :P |
Techassi
deleted the
feat/versioned-support-generics-in-plain-from-impl
branch
September 29, 2026 07:34
marc-merino
pushed a commit
to marc-merino/operator-rs
that referenced
this pull request
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the plain
Fromimpl (not the tracking one), the#[versioned]macro now emits/supports generics of the versioned struct.