feat: Support floating tag in product image selection#1226
Draft
Techassi wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for auto updating product images. This is done by using a floating tag for product images instead of fully-qualified ones.
Significant changes are:
Add a new
autoUpdatefield to the product image selection CRD interface:Change the default
pullPolicyfromAlwaystoIfNotPresent. This better aligns with theauto update feature, because if enabled, the pull policy is automatically set to
Always. Thecurrent default is (as far as I can see) a leftover from the past. Even the doc comment states
that
Alwaysis the default, as we support floating tags (not true).The
stackableVersionfield is now a proper semantic version, instead of a plain string. This isneeded, to correctly extract the floating tag if the auto update is enabled.
This PR also serves as a decision. Please vote with 👍 or 👎 or leave comments.