feat: Add generic database connection mechanism#1163
Open
feat: Add generic database connection mechanism#1163
Conversation
This reverts commit 8e05224. It was actually mot needed :)
19 tasks
sbernauer
commented
Mar 4, 2026
| #[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct GenericCeleryDatabaseConnection { | ||
| /// The name of the Secret that contains an `uri` key with the complete SQLAlchemy URI. |
Member
Author
There was a problem hiding this comment.
Copied over from https://github.com/stackabletech/airflow-operator/pull/743/changes#r2786318061:
I feel URI is very generic. I think connectionString is a better description?
sbernauer
commented
Mar 4, 2026
| /// Returns the JDBC connection details for the given `unique_database_name` using the | ||
| /// default [`TemplatingMechanism`]. | ||
| /// | ||
| /// `unique_database_name` identifies this particular database connection within the operator |
Member
Author
There was a problem hiding this comment.
marker: Improve docs a bit on avoiding clashing env var names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#238
Definition of Done Checklist
Author
Reviewer
Acceptance