refactor: Extract apply and update status steps - #872
Open
maltesander wants to merge 3 commits into
Open
Conversation
Moves resource application and status computation out of the reconcile function and into dedicated controller/apply.rs and controller/update_status.rs modules, following the same shape as the airflow (#828) and hbase (#787) operators. reconcile_opa is now just validate, build, apply, update_status. KubernetesResources gains a type-state marker (Prepared, Applied), so update_status can only be called with resources that were actually applied, not merely built. Applier::apply destructures KubernetesResources without a rest pattern, so a new resource kind fails to compile instead of silently never being applied. The legacy "opacluster" field manager patch (see #444) becomes a private method on the Applier, running against the applied DaemonSets. Only the name and namespace are read from those objects, so this is equivalent to the previous behaviour. Note that delete_orphaned_resources now runs before the status patch instead of after it, matching the template operators.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
controller/apply.rs) with anApplier, which owns theClusterResources, applies every resource kind and deletes orphaned resourcescontroller/update_status.rs), which computes theOpaClusterStatusfrom the applied resourcesKubernetesResources(Prepared,Applied), soupdate_statuscan only be called with resources that were actually applied, not merely built.Applier::applydestructuresKubernetesResourceswithout a rest pattern, so a new resource kind fails to compile instead of silently never being applied.Applier, running against the applied DaemonSets. Only the name and namespace are read from those objects, so this is equivalent to the previous behaviour.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker