Skip to content

fix: Honour image.pullSecrets in the CSI provisioner Deployment - #417

Open
lfrancke wants to merge 1 commit into
mainfrom
push-nsmrlsqowwxy
Open

fix: Honour image.pullSecrets in the CSI provisioner Deployment#417
lfrancke wants to merge 1 commit into
mainfrom
push-nsmrlsqowwxy

Conversation

@lfrancke

@lfrancke lfrancke commented Aug 8, 2026

Copy link
Copy Markdown
Member

Description

The CSI provisioner Deployment read .Values.imagePullSecrets, while the node driver DaemonSet and values.yaml both use .Values.image.pullSecrets.

Looks like this was forgotten back in 2024 in #142.

I'd consider this a bug fix as the provisioner never received pull secrets this way.

Found while surveying the charts for values that templates read but values.yaml does not define.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

The Deployment read .Values.imagePullSecrets while the DaemonSet and values.yaml
both use .Values.image.pullSecrets. Nothing defines imagePullSecrets, so the
provisioner never received pull secrets: on a private registry the node driver
starts and the provisioner fails to pull its image.
@lfrancke lfrancke self-assigned this Aug 8, 2026
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

1 participant