Conversation
dervoeti
force-pushed
the
chore/pin-build-tooling
branch
from
September 30, 2026 09:14
94a25c1 to
13e189e
Compare
dervoeti
force-pushed
the
chore/pin-build-tooling
branch
from
September 30, 2026 13:07
13e189e to
66608ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some build tooling is invoked without a pinned version, so it could change between two builds of the same image version. This could cause builds to break and also introduce malicious packages dependencies in the supply chain.
This PR pins or restricts it.
Maven:
mvn versions:setinvokes the plugin by prefix. Unless the project POM pins it, Maven resolves the latest release on every build. It is now pinned to2.22.0, the version that resolves today.npm global installs:
The global installs (like
cdxgenoryarn) pin the top-level version, but their transitive dependencies float.I decided against vendoring lockfiles for these to keep it simple (we can do that once we have a good solution for Renovate updates) and just hardened the installation used two flags instead:
--ignore-scripts: install scripts of the package and its dependencies no longer run. They are a common way npm malware executes.--before=<now - 7 days>: npm only resolves versions, including transitive ones, that were published at least 7 days ago, so a freshly published malicious version is not picked up before it is taken down.As a consequence, a pinned version must be at least 7 days old, otherwise the install fails.
Superset npm:
nvm install --latest-npminstalled whatever npm version was newest at build time. npm is now pinned vianpm-versioninboil-config.toml(10.9.9for both versions, the newest release compatible with both Node versions) and installed with the same flags.Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.