Skip to content

Replace the Terms component with plain tables - #129

Merged
RaviTejaKNTS merged 2 commits into
mainfrom
fix/ad-network-metrics-layout
Nov 14, 2026
Merged

RaviTejaKNTS merged 2 commits into
mainfrom
fix/ad-network-metrics-layout

Conversation

@RaviTejaKNTS

Copy link
Copy Markdown
Collaborator

What and why

The traffic terms section on /ad-networks showed as a browser-default definition list (plain terms, meanings indented 40px). That page wraps its article in its own class, so the shared .prose dl styles never applied. The owner chose to drop the Terms component and use plain tables everywhere.

Changes

  • All 40 terms in 8 MDX files are now two-column Markdown tables, with words unchanged and headers that fit each page: ad-networks, platform-fees, launch-directories (how-we-check, link-types), caa-checker, domain-age, churn-rate-converter, startup-runway-calculator.
  • Deleted Terms and Term, their MDX mapping, the .prose dl/dt/dd styles, and the Components UI example. The content check now rejects <Terms>.
  • ContentMarkdown (course text from the database) turns Term\n: Meaning lists into the same table instead of a dl, so nothing depends on the deleted styles.
  • The content export writes a table, escapes pipes, and stops with a source-line error when a meaning has more than one paragraph or block instead of flattening it.
  • page-content.md and shared-ui.md say to use a table for terms.

Checks

  • npm run quality: pass, 129 core tests.
  • tests/stack127/page-content.test.mjs: pass, 21 tests, including the new multi-block rejection.
  • All 7 pages checked in the dev server at 1280px and 390px: tables render with header and borders, no sideways scroll, text wraps cleanly on phones.
  • Reviewer pass: all 40 terms match word for word, no references left. Its two findings (course dl styles still used, nested meanings flattened into raw table text) are fixed in this PR.

🤖 Generated with Claude Code

The Terms list rendered as a browser-default definition list on
/ad-networks, where the article is not inside the shared prose styles.
Every terms list is now a two-column Markdown table, which brings its
own table styles on any page.

- Convert all 40 terms in 8 MDX files to tables, words unchanged.
- Delete Terms and Term, their prose styles, and the gallery example.
- Course text from the database turns term lists into tables too.
- The content export writes a table and stops on a meaning with more
  than one block instead of flattening it.
- Docs say to use a table for terms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RaviTejaKNTS
RaviTejaKNTS merged commit c82ce31 into main Nov 14, 2026
4 checks passed

This branch was previously deployed

1 inactive deployment
production — 977a1a5d Deployed Nov 14, 2026 by RaviTejaKNTS via verify-production-build #121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant