Repository navigation
Recognize ad code that speed and consent plugins delay - #125
Merged
Merged
Conversation
Matcher ad-network-1.5.2. The matcher read only executable scripts, so AdSense and page signatures loaded through plugins such as LiteSpeed (type="litespeed/javascript" data-src=...) were recorded as absent and live relationships ended. In a production batch of 24, curl found the original ID on 22 to 24 pages while the checker found it on 1. - An audited allow-list of 19 deferred-loader and consent formats. Only each loader's own activation attribute, or a plain src where that loader supports it, can confirm. Conflicting sources, held inline bodies with a signal, and parse failures are inconclusive. Restored non-JavaScript types are ignored. - Ordinary executable scripts match as in 1.4.0; scripts inside pre, code and blockquote are read again. - The correction is split. History repair (erase the departure, invalidate snapshots) needs stored proof of a false miss. Current-only reconfirmation keeps the departure and records one return. - Runbook: acceptance queries, resume of every paused job, and the hourly verification resumed last. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RaviTejaKNTS
had a problem deploying
to
production
November 13, 2026 15:19 — with 
GitHub Actions
Failure
GitHub Actions
Failure
RaviTejaKNTS
temporarily deployed
to
production
November 13, 2026 15:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/ad-networks/matcher.mjsconfirmed AdSense and page signatures only in executable scripts. Speed and consent plugins rewrite tags, for example<script type="litespeed/javascript" data-src="…adsbygoogle.js?client=ca-pub-…">, so live sites were recorded as absent and ended. In the first production correction batch (24 sites),curlfrom OVH found the original ID on 22 of 24 homepages; the checker confirmed 1.Change (matcher
ad-network-1.5.2)content_docs/ad-networks/maintenance.md. Only the loader's own activation attribute (or plainsrcwhere that loader supports it) can confirm.6a90331d. Scripts insidepre,code,blockquoteare read again.correct-homepage-misses.mjsis split in two:Review
Four review rounds by a separate reviewer: 3, then 2, then 1 blockers, then none. The last finding (the no-window resume command failing on an empty SSH argument) was fixed by the lead.
Checks
npm run quality: TypeScript and 113 core tests passed.After merge
Hourly verification on OVH stays paused. Run the correction by the runbook: 25 domains, then 100-domain batches, then resume verification.
🤖 Generated with Claude Code