Skip to content

Conversation

@alukach
Copy link
Collaborator

@alukach alukach commented Dec 1, 2025

closes #394

@vincentsarago
Copy link
Member

should we add some tests as well ?

@bitner
Copy link
Collaborator

bitner commented Dec 1, 2025

pgstac.sql is created by concatenating the separated .sql files, changes need to be made in the organized sql files

@bitner
Copy link
Collaborator

bitner commented Dec 1, 2025

@alukach It doesn't look like the tests are passing here

@alukach
Copy link
Collaborator Author

alukach commented Dec 1, 2025

@bitner Yeah, I think my fix actually doesn't work 🙃

Does anything stand out to you in the code changes that wouldn't work as I am expecting (ie not including collection by default in includes)?

--- tests/basic/collection_searches.sql.out	Mon Dec  1 19:25:07 2025
***************
*** 708,710 ****
  select collection_search('{"ids":["testcollection_1","testcollection_2"], "fields": {"include": ["title"]}}');
!  {"links": [], "collections": [{"id": "testcollection_1", "title": "My Test Collection.", "collection": null}, {"id": "testcollection_2", "title": "My Test Collection.", "collection": null}], "numberMatched": 2, "numberReturned": 2}
!
--- 60,61 ----
  select collection_search('{"ids":["testcollection_1","testcollection_2"], "fields": {"include": ["title"]}}');
!  {"links": [], "collections": [{"id": "testcollection_1", "title": "My Test Collection."}, {"id": "testcollection_2", "title": "My Test Collection."}], "numberMatched": 2, "numberReturned": 2}
+ echo '***TEST FOR tests/basic/collection_searches.sql FAILED***'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"collection" attribute returned from collection_search() with "fields.include"

3 participants