Skip to content

Better logging of API errors #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better logging of API errors #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions python/create_readme.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
if "GITHUB_TOKEN" in env:
headers["Authorization"] = " ".join(["Bearer", os.environ["GITHUB_TOKEN"]])
else:
logger.warn("No GITHUB_TOKEN found in env")
logger.warning("No GITHUB_TOKEN found in env")

def from_gh(response, external = False) -> dict:
data = {
Expand All @@ -40,6 +40,7 @@ def get_sources() -> list:
try:
logger.info(f"Reading list of repositories")
with requests.get("https://api.github.com/users/stac-extensions/repos?per_page=1000", headers=headers) as site:
site.raise_for_status()
repos = site.json()
for repo in repos:
if not isinstance(repo, dict):
Expand All @@ -55,6 +56,7 @@ def get_sources() -> list:
try:
logger.info(f"Reading community repos individually")
with requests.get(f"https://api.github.com/repos/{r[0]}/{r[1]}", headers=headers) as repo:
repo.raise_for_status()
data.append(from_gh(repo.json(), True))
except error as e:
logger.error(f"community repo not available: {e}")
Expand All @@ -75,8 +77,9 @@ def get_extensions() -> list:
src["version"] = unknown
if "tags" in src:
try:
with requests.get(src["tags"], headers=headers) as tags:
tags = tags.json()
with requests.get(src["tags"], headers=headers) as response:
response.raise_for_status()
tags = response.json()
if len(tags) > 0:
src["version"] = re.sub(r"^v", "", tags[0]["name"])
try:
Expand Down