Add .NET 10 target and make use of C#14 extension members #1672
+851
−1,125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mus65
force-pushed
the
net10
branch
2 times, most recently
from
946d39d to
9283535
Compare
Rob-Hague
reviewed
Sep 11, 2025
Contributor
Author
|
@Rob-Hague I created a separate PR for extension members #1699. I figured it's easier to review this separately. Or should I just add it here? |
Collaborator
|
Don't mind, if it's in separate commits then happy for it to be in 1 pr if it makes branch management easier |
Contributor
Author
|
Merged the extension member changes into this PR. |
mus65
changed the title
Rob-Hague
reviewed
Sep 27, 2025
Rob-Hague
reviewed
Sep 27, 2025
This is fixed in the final release. This reverts commit 5a59ac9.
Rob-Hague
reviewed
Nov 13, 2025
src/Renci.SshNet/Abstractions/RandomNumberGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
Rob-Hague
approved these changes
Nov 15, 2025
Collaborator
|
The fewer analyzers the better imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new target and fixes/suppresses new analyzer warnings.
Also make use of the C# 14 extension members to get rid of most
ThrowHelpermethods and some#if.There may be more places to make use of it (or maybe I already overdid it 😄 ).