Skip to content

chore(ci): replace SourceKnight with setup-sp - #33

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 18, 2026
Merged

chore(ci): replace SourceKnight with setup-sp#33
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

  • Replace the SourceKnight-based CI (maxime1907/action-sourceknight) with a native GitHub Actions workflow.
  • Compile with rumblefrog/setup-sp@v1.3.1, pinned to SourceMod 1.12.x, and spcomp directly.
  • Dependency (sm-plugin-PlayerManager) is now cloned straight from its git repo during the build step instead of resolved via sourceknight.yaml.
  • Package step still bundles the compiled plugin .smx alongside the addons/sourcemod/gamedata directory (no configs directory in this repo).
  • Auto-release flow preserved: pushes to master/main retag latest, tag pushes and master/main pushes trigger a GitHub release with the packaged archive.
  • Removed sourceknight.yaml and its .sourceknight cache entry from .gitignore; updated .github/copilot-instructions.md build/CI references accordingly.

Test plan

  • Confirm the Build job compiles Status.sp successfully in GitHub Actions
  • Confirm the packaged artifact contains the plugin .smx and gamedata
  • Confirm release/tag jobs behave as before on merge to master

Copilot AI lite review requested due to automatic review settings August 17, 2026 18:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway force-pushed the chore/drop-sourceknight branch from 1d83dd9 to 75387e4 Compare August 18, 2026 08:04
@Rushaway
Rushaway merged commit ada6604 into master Aug 18, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 18, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants