fix: webhook query string, inverted bounds checks and handle leaks

[Rushaway]

Summary

While reviewing the include I found a few real bugs (one of them breaks Webhook.Edit()), some handle leaks, and a couple of rough edges in example.sp / README.md. Everything here is behaviour-preserving except where the previous behaviour was broken.

Bugs fixed

Webhook.Execute() built an invalid query string

Format(webhook_query, sizeof webhook_query, "%s?thread_id=%s&?wait=true", webhook, threadID);

The &?wait=true makes the parameter name ?wait instead of wait. Discord then treats wait as false, replies 204 No Content instead of 200 with the message body, and OnWebHookExecuted can no longer read the message id → Webhook.Edit() is unusable whenever a thread ID is passed. Fixed to &wait=true.

Also: when thread_name is set, the thread_id query parameter is now omitted, because Discord rejects a forum webhook that carries both (error 220002). Previously only example.sp worked around this.

Embed.GetField() / Webhook.GetEmbed() inverted bounds check

if(fields != null && fields.Length < index)   // wrong

For an array of length 3, GetField(0) returns null and GetField(5) reads out of bounds. Every valid index fails. Changed to index >= 0 && index < fields.Length.

Handle leaks

AddField(), AddEmbed(), GetField() and GetEmbed() obtain a JSONArray handle (new JSONArray() or this.Get(...), which json_increfs) and never delete it. Added the missing delete.

Sub-object getters raised a native error

GetFooter, GetImage, GetThumbnail, GetVideo, GetProvider, GetAuthor, GetFields, GetEmbeds call this.Get("<key>"), which throws Could not retrieve value for key when the key is absent. They now return null first via HasKey.

Embed.SetTimeStampNow() malformed format string

"%FT\%T.000%z" contains a stray escape (\%). Replaced with an explicit, portable "%Y-%m-%dT%H:%M:%S%z".

DEBUG build path

this.toString(...) (wrong case, does not compile) → this.ToString(...), and the JSON is now printed with PrintToServer("%s", debug) instead of being used as the format string.

Improvements

• URL buffers in Execute() / Edit() are sized from WEBHOOK_URL_MAX_SIZE instead of a bare 1024 that a near-maximum-length webhook URL plus ?thread_id=…&wait=true could overflow.
• Webhook.SetThreadName() now takes const char[] (so string literals are accepted) and its doc reflects the real Discord limit of 100 characters (WEBHOOK_THREAD_NAME_MAX_SIZE), not 1000.
• Added Webhook.GetThreadName().
• DiscordWebhookAPI_VERSION bumped to 1.1.0 + changelog entry.

example.sp

• PrintToServer("… n°%s …", client) used %s with an int → %d.
• The DataPack passed to Execute() / Edit() was never freed in the callbacks.
• PrintToServer(messageId) → PrintToServer("%s", messageId).

README.md

• Snippet checked HTTPStatus_NoContent, but Execute() always appends wait=true so Discord answers 200 OK; also delete the webhook, drop the trailing slash (the doc explicitly warns against it) and use discord.com.

Notes

• The Discord API version used is entirely determined by the webhook URL the caller passes; an unversioned URL currently resolves to the deprecated v6. Defaulting the wrapper to /api/v10/ is a behaviour change worth discussing separately — opened as an issue on the upstream repo (issues are disabled here).

Testing

example.sp still compiles (CI). GetField / GetEmbed / the sub-object getters are not exercised by example.sp; changes there are straightforward.

🤖 Generated with Claude Code