Skip to content

mark ticketBoards import step as optional#53

Open
Deenk wants to merge 2 commits into
mainfrom
work/dw/ninjaone-tickets-import-optional
Open

mark ticketBoards import step as optional#53
Deenk wants to merge 2 commits into
mainfrom
work/dw/ninjaone-tickets-import-optional

Conversation

@Deenk
Copy link
Copy Markdown
Contributor

@Deenk Deenk commented May 28, 2026

📋 Summary

Fixes a 500 at import time for NinjaOne tenants that don't have the
Ticketing module enabled. The /v2/ticketing/trigger/boards endpoint
returns "Ninja Ticketing Integration is not enabled" for these tenants,
which was failing the entire import.

Marks the ticketBoards import step as optional: true, so the step
finalises with a warning status instead of failing the whole import
when the read errors.


🔗 Related issue(s)


🧩 Plugin details

  • Plugin name: NinjaOne
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

NinjaOne tenants without the Ticketing module enabled fail the whole
import with a 500 from the boards endpoint. Marking the step optional
lets the import finish with a warning instead.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@Deenk Deenk marked this pull request as ready for review May 28, 2026 15:10
@Deenk Deenk requested a review from a team May 28, 2026 15:10
@Deenk Deenk self-assigned this May 28, 2026
@Deenk Deenk added the bug Something isn't working label May 28, 2026
Comment thread plugins/NinjaOne/v1/indexDefinitions/default.json
@github-actions
Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/NinjaOne/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

ninja-one
{
  "valid": true,
  "pluginName": "ninja-one",
  "pluginType": "cloud",
  "summary": {
    "Data Streams": 37,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

@Deenk Deenk requested a review from clarkd June 1, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working plugin: NinjaOne

Development

Successfully merging this pull request may close these issues.

2 participants